[VMware] Full OVF properties support by nvazquez · Pull Request #4235 · apache/cloudstack

nvazquez · 2020-07-31T04:54:09Z

Description

WIP description...

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

yadvr · 2020-08-05T08:28:31Z

@blueorangutan package

blueorangutan · 2020-08-05T08:28:57Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

yadvr · 2020-08-05T08:29:37Z

@nvazquez @shwstppr unit tests are failing, please review travis or local build and fix. I see:

...
[ERROR] testCheckAffinityNullPreferredHosts(com.cloud.vm.DeploymentPlanningManagerImplTest) Time elapsed: 0.005 s <<< ERROR!
org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'deploymentPlanningManagerImpl': Unsatisfied dependency expressed through field 'templateDao'; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'com.cloud.storage.dao.VMTemplateDao' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {@javax.inject.Inject()}
at com.cloud.vm.DeploymentPlanningManagerImplTest.testSetUp(DeploymentPlanningManagerImplTest.java:158)
Caused by: org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'com.cloud.storage.dao.VMTemplateDao' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {@javax.inject.Inject()}
at com.cloud.vm.DeploymentPlanningManagerImplTest.testSetUp(DeploymentPlanningManagerImplTest.java:158)
[ERROR] Errors: [ERROR] DeploymentPlanningManagerImplTest.testSetUp:158 » UnsatisfiedDependency Error ...
[ERROR] DeploymentPlanningManagerImplTest.testSetUp:158 » UnsatisfiedDependency Error ...
[ERROR] DeploymentPlanningManagerImplTest.testSetUp:158 » UnsatisfiedDependency Error ...
[ERROR] DeploymentPlanningManagerImplTest.testSetUp:158 » UnsatisfiedDependency Error ...
[ERROR] DeploymentPlanningManagerImplTest.testSetUp:158 » UnsatisfiedDependency Error ...
[ERROR] DeploymentPlanningManagerImplTest.testSetUp:158 » UnsatisfiedDependency Error ...
[ERROR] DeploymentPlanningManagerImplTest.testSetUp:158 » UnsatisfiedDependency Error ...
[ERROR] Tests run: 846, Failures: 0, Errors: 7, Skipped: 5
...

blueorangutan · 2020-08-05T08:46:52Z

Packaging result: ✖centos7 ✖debian. JID-1654

yadvr · 2020-08-05T09:42:16Z

@blueorangutan package

blueorangutan · 2020-08-05T09:43:02Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

DaanHoogland · 2020-08-05T09:44:38Z

@blueorangutan package

@rhtyd why do you restart this, it has unit test failures? Did i miss a fix for those since they apeared?

blueorangutan · 2020-08-05T09:45:57Z

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

shwstppr · 2020-08-05T09:46:26Z

working on the unit test fix

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2020-08-05T09:52:18Z

@blueorangutan package

blueorangutan · 2020-08-05T09:52:57Z

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-08-05T10:26:39Z

Packaging result: ✔centos7 ✔debian. JID-1661

yadvr · 2020-08-05T10:38:13Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2020-08-05T10:38:57Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

nvazquez · 2020-08-05T18:20:51Z

@blueorangutan package

blueorangutan · 2020-08-05T18:22:02Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-08-05T18:53:52Z

Packaging result: ✔centos7 ✔debian. JID-1664

nvazquez · 2020-08-05T20:07:46Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2020-08-05T20:09:03Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2020-08-06T10:18:07Z

Trillian test result (tid-2276)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49309 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4235-t2276-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 66 look OK, 12 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_3d_gpu_support	`Error`	327.04	test_deploy_vgpu_enabled_vm.py
test_00_deploy_vm_root_resize	`Failure`	278.67	test_deploy_vm_root_resize.py
test_01_add_delete_kubernetes_supported_version	`Error`	1807.57	test_kubernetes_supported_versions.py
test_reboot_router	`Error`	239.07	test_network.py
test_03_nic_multiple_vmware	`Error`	360.91	test_nic.py
test_10_project_activation	`Error`	27.79	test_projects.py
test_01_reset_vm_on_reboot	`Error`	17.48	test_reset_vm_on_reboot.py
test_08_start_router	`Error`	13.38	test_routers.py
test_09_reboot_router	`Error`	1.10	test_routers.py
test_04_change_offering_small	`Error`	20.67	test_service_offerings.py
test_05_stop_ssvm	`Failure`	920.82	test_ssvm.py
test_06_stop_cpvm	`Failure`	919.71	test_ssvm.py
test_07_reboot_ssvm	`Failure`	36.81	test_ssvm.py
test_01_volume_usage	`Error`	90.60	test_usage.py
test_07_start_vm	`Error`	17.45	test_vm_life_cycle.py
test_08_reboot_vm	`Error`	1.10	test_vm_life_cycle.py
test_11_migrate_vm	`Error`	52.91	test_vm_life_cycle.py

yadvr · 2020-08-06T10:48:08Z

@nvazquez there are also Travis/simulator tests failing, pl check. I'll kick test against KVM for regression checks.

@blueorangutan test

blueorangutan · 2020-08-06T10:48:57Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

nvazquez · 2020-08-06T18:31:06Z

Closing this PR - moving work to PR #4250

blueorangutan · 2020-08-06T23:30:49Z

Trillian test result (tid-2283)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43727 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4235-t2283-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_04_rvpc_network_garbage_collector_nics	`Error`	3855.17	test_vpc_redundant.py

DaanHooglandand others added 30 commits July 30, 2020 21:33

pokemon anihilation and class-javadoc
fa3e30e

add ovf properties to template details
41ebfd0

disected ova processing
432797e

import
39722ee

ovf string props hack
08d57ac

refactor plan in comments
34d10ff

trace
81f16a0

hack to deal with: ovf property attributes in details
bda8848

PoC code for properties iso
4bd8b37

flag for deploy as is
3c219fc

factor out 700 line start command and callees
0093a3b

execute start; init of disk info factorred out
0768d3d

license
43d5f2b

howto pass deploy OVA as is?
3affec5

logging during ingestion and guest net creation
0e47904

more todos in comment
80a77d3

tested in production '{' is really needed
7ab0e7e

deploy ovf without stripping networks
925acc9

deploy as is parameter to DB
83fff23

show deploy as is hack
9306f33

extract extension
f0c0ce7

path correction
e70f78e

further disect of start
892c780

ui strings
0fde9d9

parse networks for later reconsiliation
e0594cf

debug and trace on registration time template processing
5592b00

logging and NPE fixes
c544cdd

template size over all disks
021032a

template details to contain json descriptions
9e134d7

make deployasis default in API
16f269e

npe fix for network map
d97817b
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

apache deleted a comment from blueorangutan Aug 5, 2020

unit test fix
98092f1
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstpprand others added 2 commits August 5, 2020 16:31

wip: vapps vm smoke test
ebdc456
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Register templates as non-deploy-as-is if empty field
31af4fd

nvazquez closed this Aug 6, 2020

Uh oh!

Conversation

nvazquez commented Jul 31, 2020

Description

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

yadvr commented Aug 5, 2020

Uh oh!

blueorangutan commented Aug 5, 2020

Uh oh!

yadvr commented Aug 5, 2020

Uh oh!

blueorangutan commented Aug 5, 2020

Uh oh!

yadvr commented Aug 5, 2020

Uh oh!

blueorangutan commented Aug 5, 2020

Uh oh!

DaanHoogland commented Aug 5, 2020

Uh oh!

blueorangutan commented Aug 5, 2020

Uh oh!

shwstppr commented Aug 5, 2020

Uh oh!

shwstppr commented Aug 5, 2020

Uh oh!

blueorangutan commented Aug 5, 2020

Uh oh!

blueorangutan commented Aug 5, 2020

Uh oh!

yadvr commented Aug 5, 2020

Uh oh!

blueorangutan commented Aug 5, 2020

Uh oh!

nvazquez commented Aug 5, 2020

Uh oh!

blueorangutan commented Aug 5, 2020

Uh oh!

blueorangutan commented Aug 5, 2020

Uh oh!

nvazquez commented Aug 5, 2020

Uh oh!

blueorangutan commented Aug 5, 2020

Uh oh!

blueorangutan commented Aug 6, 2020

Uh oh!

yadvr commented Aug 6, 2020

Uh oh!

blueorangutan commented Aug 6, 2020

Uh oh!

nvazquez commented Aug 6, 2020

Uh oh!

blueorangutan commented Aug 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants