api: Add 'created' field to API response by Pearl1594 · Pull Request #5210 · apache/cloudstack

Pearl1594 · 2021-07-15T14:27:30Z

Description

Fixes: #5209
This PR adds 'created' field to the response of listing Networks, VPCs, Projects, NetworkOffering

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Pearl1594 · 2021-07-15T14:27:49Z

@blueorangutan package

blueorangutan · 2021-07-15T14:28:03Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-07-15T14:53:59Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 558

GabrielBrascher

There are a couple of pending additions raised by @DaanHoogland regarding API "since 4.16.0.0" and an autogenerated commented line that could be removed (in my opinion).

Despite these small adjustments, code LGTM.

Pearl1594 · 2021-07-19T06:06:14Z

@blueorangutan package

blueorangutan · 2021-07-19T06:07:02Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-07-19T06:29:07Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 582

davidjumani · 2021-07-19T06:31:06Z

@blueorangutan test

blueorangutan · 2021-07-19T06:32:03Z

@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

nvazquez · 2021-07-19T11:53:35Z

Thanks @davidjumani
@Pearl1594 can you please address the open comments? Look like minor changes

Pearl1594 · 2021-07-19T12:07:29Z

@nvazquez the comments have been addressed. Thanks

nvazquez · 2021-07-19T18:57:12Z

Thanks @Pearl1594, waiting for test results and should be to merge

blueorangutan · 2021-07-20T00:49:58Z

Trillian test result (tid-1311)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 64197 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5210-t1311-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_storage_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 79 look OK, 10 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true	`Failure`	344.57	test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false	`Failure`	347.54	test_routers_network_ops.py
test_03_ssvm_internals	`Failure`	14.45	test_ssvm.py
ContextSuite context=TestVMWareStoragePolicies>:setup	`Error`	0.00	test_storage_policy.py
test_02_create_template_with_checksum_sha1	`Error`	65.39	test_templates.py
test_03_create_template_with_checksum_sha256	`Error`	65.37	test_templates.py
test_04_create_template_with_checksum_md5	`Error`	65.40	test_templates.py
test_05_create_template_with_no_checksum	`Error`	65.37	test_templates.py
test_04_extract_template	`Failure`	128.33	test_templates.py
ContextSuite context=TestISOUsage>:setup	`Error`	0.00	test_usage.py
test_01_volume_usage	`Failure`	787.40	test_usage.py
test_10_attachAndDetach_iso	`Failure`	1510.31	test_vm_life_cycle.py
test_06_download_detached_volume	`Failure`	425.91	test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup	`Error`	0.00	test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup	`Error`	0.00	test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py

nvazquez · 2021-07-20T02:31:17Z

@Pearl1594 @DaanHoogland please kick another round of packaging + test after PR #5218 is merged

blueorangutan · 2021-07-20T08:19:31Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 597

sureshanaparti

code LGTM

sureshanaparti · 2021-07-20T09:18:58Z

@blueorangutan test

blueorangutan · 2021-07-20T09:20:09Z

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-07-20T20:35:34Z

Trillian test result (tid-1322)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37953 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5210-t1322-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Smoke tests completed. 88 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	1031.25	test_privategw_acl.py

nvazquez · 2021-07-20T21:03:58Z

Merging based on approvals and test results, failure seems unrelated

api: Add 'created' field to API response
f08b2e0

Pearl1594 requested a review from DaanHoogland July 15, 2021 14:27

sureshanaparti reviewed Jul 15, 2021
View reviewed changes

Comment threadapi/src/main/java/org/apache/cloudstack/api/response/ProjectResponse.java

nvazquez added component:UI Severity:Minor labels Jul 16, 2021

nvazquez added this to the 4.16.0.0 milestone Jul 16, 2021

DaanHoogland reviewed Jul 16, 2021
View reviewed changes

Comment threadapi/src/main/java/org/apache/cloudstack/api/response/ProjectResponse.java Outdated

GabrielBrascher approved these changes Jul 16, 2021
View reviewed changes

Comment threadapi/src/main/java/com/cloud/network/NetworkProfile.java Outdated

address comments
86b091c

davidjumani approved these changes Jul 19, 2021
View reviewed changes

nvazquez closed this Jul 19, 2021

nvazquez reopened this Jul 19, 2021

sureshanaparti approved these changes Jul 20, 2021
View reviewed changes

nvazquez merged commit 1f743e9 into apache:mainJul 20, 2021

Uh oh!

Conversation

Pearl1594 commented Jul 15, 2021

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

Pearl1594 commented Jul 15, 2021

Uh oh!

blueorangutan commented Jul 15, 2021

Uh oh!

blueorangutan commented Jul 15, 2021

Uh oh!

Uh oh!

Uh oh!

GabrielBrascher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Pearl1594 commented Jul 19, 2021

Uh oh!

blueorangutan commented Jul 19, 2021

Uh oh!

blueorangutan commented Jul 19, 2021

Uh oh!

davidjumani commented Jul 19, 2021

Uh oh!

blueorangutan commented Jul 19, 2021

Uh oh!

nvazquez commented Jul 19, 2021

Uh oh!

Pearl1594 commented Jul 19, 2021

Uh oh!

nvazquez commented Jul 19, 2021

Uh oh!

blueorangutan commented Jul 20, 2021

Uh oh!

nvazquez commented Jul 20, 2021

Uh oh!

blueorangutan commented Jul 20, 2021

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Jul 20, 2021

Uh oh!

blueorangutan commented Jul 20, 2021

Uh oh!

blueorangutan commented Jul 20, 2021

Uh oh!

nvazquez commented Jul 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants