Skip to content

Revert "Externalize kvm agent storage timeout configuration" - #5218

Merged
DaanHoogland merged 1 commit into
mainfrom
revert-4585-externalize-kvm-agent-storage-timeout-configuration
Jul 20, 2021
Merged

Revert "Externalize kvm agent storage timeout configuration"#5218
DaanHoogland merged 1 commit into
mainfrom
revert-4585-externalize-kvm-agent-storage-timeout-configuration

Conversation

@DaanHoogland

@DaanHooglandDaanHoogland commented Jul 19, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Reverts #4585

this has been tested locally, #4585 introduced a regression where KVM hosts could not be added to a zone. It was not found in older smoke tests setups, so probably introduced in combination with some other PR that got merged between the smoketest run and the merge of #4585.

@nvazquez

nvazquez commented Jul 19, 2021

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

blueorangutan commented Jul 19, 2021

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@nvazqueznvazquez mentioned this pull request Jul 19, 2021
Closed
@blueorangutan

blueorangutan commented Jul 19, 2021

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 590

@nvazquez

nvazquez commented Jul 19, 2021

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

blueorangutan commented Jul 19, 2021

Copy link
Copy Markdown

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@nvazqueznvazquez mentioned this pull request Jul 20, 2021
Merged
10 tasks
@nvazqueznvazquez added this to the 4.16.0.0 milestone Jul 20, 2021
@blueorangutan

blueorangutan commented Jul 20, 2021

Copy link
Copy Markdown

Trillian test result (tid-1319)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40004 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5218-t1319-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 89 look OK, 0 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File

nvazquez
nvazquez approved these changes Jul 20, 2021
View reviewed changes

@nvazqueznvazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

harikrishna-patnala
harikrishna-patnala approved these changes Jul 20, 2021
View reviewed changes

@harikrishna-patnalaharikrishna-patnala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see @GutoVeronezi also agreed to revert PR#4585 now. So LGTM

@yadvr

yadvr commented Jul 20, 2021

Copy link
Copy Markdown
Member

Lgtm

@DaanHoogland
DaanHoogland merged commit 6f93e5c into mainJul 20, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harikrishna-patnalaharikrishna-patnalaharikrishna-patnala approved these changes
@nvazqueznvazqueznvazquez approved these changes
@GutoVeroneziGutoVeroneziAwaiting requested review from GutoVeronezi
@GabrielBrascherGabrielBrascherAwaiting requested review from GabrielBrascher

Assignees

No one assigned

Labels

Severity:CriticalCritical bugtype:regression

Projects

None yet

Milestone

4.16.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@DaanHoogland@nvazquez@blueorangutan@yadvr@harikrishna-patnala