Uh oh!
There was an error while loading. Please reload this page.
CLOUDSTACK-8749: KVM - cleanup linklocal interface based on names - #718
Closed
yadvr wants to merge 1 commit into
Closed
CLOUDSTACK-8749: KVM - cleanup linklocal interface based on names#718yadvr wants to merge 1 commit into
yadvr wants to merge 1 commit into
Conversation
This tries to avoid cleaning by a device name. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
asfbot
commented
Aug 19, 2015
cloudstack-pull-rats #352 ABORTED |
remibergsma
commented
Aug 19, 2015
Contributor
LGTM |
asfbot
commented
Aug 19, 2015
cloudstack-pull-analysis #284 ABORTED |
milamberspace
commented
Aug 19, 2015
Contributor
LGTM |
remibergsma
commented
Aug 19, 2015
Contributor
@bhaisaab Let's make sure this ends up in master as well! |
asfgit pushed a commit
that referenced
this pull request
Aug 19, 2015
This tries to avoid cleaning by a device name. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> This closes#718
yadvr
commented
Aug 19, 2015
MemberAuthor
@remibergsma thanks, done. |
Contributor
There was a problem hiding this comment.
I am concerned about the unchecked array access in the event of malformed/unexpected input. Consider the following as a bit of extra safety in the event of malformed input beginning at line 289:
if (tokens != null && tokens.length < 2) {
// Should we emit a log warning here to indicate that we received an unexpected string format?
continue;
}
final String device = tokens[2];
if (!Strings.isNullOrEmpty(device) &&
!device.equalsIgnoreCase(linkLocalBr)) {
MemberAuthor
There was a problem hiding this comment.
For this PR we cannot make any changes now that it is merged already; perhaps send a new PR or I can pick it up later.
yadvr added a commit
to shapeblue/cloudstack
that referenced
this pull request
Aug 24, 2015
Based on @jburwell's comment on PR apache#718 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr added a commit
to shapeblue/cloudstack
that referenced
this pull request
Aug 24, 2015
Based on @jburwell's comment on PR apache#718 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr added a commit
to shapeblue/cloudstack
that referenced
this pull request
Aug 26, 2015
Based on @jburwell's comment on PR apache#718 This closesapache#735 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr added a commit
to shapeblue/cloudstack
that referenced
this pull request
Aug 26, 2015
Based on @jburwell's comment on PR apache#718 This closesapache#733 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr pushed a commit
that referenced
this pull request
Jan 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tries to avoid cleaning by a device name.