Skip to content

CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input - #733

Merged
asfgit merged 1 commit into
apache:4.5from
shapeblue:kvm-linkbr-checks
Aug 26, 2015
Merged

CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input#733
asfgit merged 1 commit into
apache:4.5from
shapeblue:kvm-linkbr-checks

Conversation

@yadvr

@yadvryadvr commented Aug 24, 2015

Copy link
Copy Markdown
Member

Based on @jburwell's comment on PR #718

@asfbot

asfbot commented Aug 24, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #377 SUCCESS
This pull request looks good

@asfbot

asfbot commented Aug 24, 2015

Copy link
Copy Markdown

cloudstack-pull-analysis #310 SUCCESS
This pull request looks good

@remibergsma

remibergsma commented Aug 24, 2015

Copy link
Copy Markdown
Contributor

@bhaisaab Can you send this PR against master please? For now, I'd rather merge to master, then cherry-pick back to 4.5 as I want to prevent all the cherry-picks in master (as we need to put them in a PR anyway in order for the tests to run first).

Once 4.6 is out and we'll be working on 4.7, we'll be able to send PRs against 4.6, then merge forward to 4.7/master.

Pinging @karuturi

@yadvr

yadvr commented Aug 24, 2015

Copy link
Copy Markdown
MemberAuthor

@remibergsma merges cleanly on master, if you LGTM; I can merge this on master and 4.5

@yadvr

yadvr commented Aug 24, 2015

Copy link
Copy Markdown
MemberAuthor

@remibergsma sending another PR just for master

@yadvr

yadvr commented Aug 24, 2015

Copy link
Copy Markdown
MemberAuthor

@remibergsma here: #735

@remibergsma

remibergsma commented Aug 24, 2015

Copy link
Copy Markdown
Contributor

@bhaisaab Thanks, now the tests can run on master as well :-)

@remibergsma

remibergsma commented Aug 24, 2015

Copy link
Copy Markdown
Contributor

LGTM on this one, will do the other once the tests are done.

@remibergsma

remibergsma commented Aug 24, 2015

Copy link
Copy Markdown
Contributor

@jburwell can you review this please? Thanks!

@jburwell

jburwell commented Aug 25, 2015

Copy link
Copy Markdown
Contributor

See comments on PR #735 regarding extracting the parsing logic and unit testing.

@yadvr
CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input
2a382e0
Based on @jburwell's comment on PR apache#718
This closesapache#733
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@asfbot

asfbot commented Aug 26, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #404 SUCCESS
This pull request looks good

@asfgit
asfgit merged commit 2a382e0 into apache:4.5Aug 26, 2015
asfgit pushed a commit that referenced this pull request Aug 26, 2015
@yadvr
Merge pull request#733from shapeblue/kvm-linkbr-checks
acf1baf
CLOUDSTACK-8749: Add checks to prevent malformed/unexpected inputBased on @jburwell's comment on PR #718
* pr/733:
CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@asfbot

asfbot commented Aug 26, 2015

Copy link
Copy Markdown

cloudstack-pull-analysis #337 UNSTABLE
Looks like there's a problem with this pull request

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yadvr@asfbot@remibergsma@jburwell@asfgit