test_templates issue

[DaanHoogland]

Description

This PR improves test_templates.py. It is also meant for trouble shooting the template failures in smoke tests as in #7345 (comment).

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7334

[codecov]

Codecov Report

Merging #8079 (26f15ea) into 4.18 (3e7f21a) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## 4.18 #8079 +/- ##
=========================================
Coverage 13.06% 13.06% Complexity 9109 9109 =========================================
Files 2720 2720 Lines 257526 257526 Branches 40150 40150 =========================================
Hits 33655 33655 Misses 219644 219644 Partials 4227 4227 

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-7941)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48808 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8079-t7941-kvm-centos7.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_arping_in_ssvm	Failure	5.16	test_diagnostics.py
test_18_retrieve_cpvm_single_file	Failure	129.31	test_diagnostics.py
test_03_deploy_vm_wrong_checksum	Failure	50.90	test_templates.py
test_03_deploy_vm_wrong_checksum	Error	50.90	test_templates.py

[shwstppr]

Code LGTM

[yadvr]

LGTM - let's test it

[DaanHoogland]

already tested it guys, and it reveals a real issue in the deploy as is test sequence. I'll give fixing it a go next week.

[yadvr]

Pl go ahead and merge if/when ready @DaanHoogland@shwstppr

[shwstppr]

@DaanHoogland cc @rohityadavcloud sorry but I created a new PR #8096 which fixes the template issues

[DaanHoogland]

obsolete