marvin,test: fix directdownload template checksum test by shwstppr · Pull Request #8096 · apache/cloudstack

shwstppr · 2023-10-14T21:12:06Z

Description

During failure while deploying a VM with the wrong checksum template, VM may be left in Error state. This PR adds code to delete such VM. Before wrong checksum test was not running correctly as the checksum parameter was not even passed while registering the template.

Fixes failures reported in #7345 (comment)

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

During failure while deploying a VM with wrong checksum template, VM may be left in Error state. This PR adds code to delete such VM. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2023-10-14T21:13:13Z

@blueorangutan package

blueorangutan · 2023-10-14T21:14:03Z

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-10-14T22:12:35Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7362

codecov · 2023-10-14T22:21:58Z

Codecov Report

Merging #8096 (60f00d1) into 4.18 (3e7f21a) will increase coverage by 0.00%.
Report is 1 commits behind head on 4.18.
The diff coverage is n/a.

@@ Coverage Diff @@## 4.18 #8096 +/- ##
=========================================
Coverage 13.06% 13.07% - Complexity 9109 9110 +1 
=========================================
Files 2720 2720 Lines 257526 257526 Branches 40150 40150 =========================================
+ Hits 33655 33661 +6 + Misses 219644 219636 -8 - Partials 4227 4229 +2

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

shwstppr · 2023-10-15T05:36:03Z

@blueorangutan test

blueorangutan · 2023-10-15T05:38:03Z

@shwstppr a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-10-15T17:29:38Z

[SF] Trillian test result (tid-7974)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41257 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8096-t7974-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	`Failure`	683.99	test_kubernetes_clusters.py

yadvr

LGTM - need to check smoketests

yadvr · 2023-10-16T07:58:33Z

@blueorangutan package

blueorangutan · 2023-10-16T08:00:06Z

@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-10-16T08:25:14Z

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 7374

shwstppr · 2023-10-16T11:51:51Z

@blueorangutan package

blueorangutan · 2023-10-16T11:54:03Z

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-10-16T12:54:26Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7382

DaanHoogland · 2023-10-16T12:56:14Z

@blueorangutan test

blueorangutan · 2023-10-16T12:58:03Z

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

DaanHoogland · 2023-10-16T13:14:46Z

+ if type(list_virtual_machine_response) == list and len(list_virtual_machine_response) > 0:
+ for virtual_machine_response in list_virtual_machine_response:
+ VirtualMachine.delete(virtual_machine_response, self.apiclient, expunge=True)


So if we succeed we added virtual_machine to self.cleanup.
If we fail we get here and are now deleting it by template_id.
it feels flacky but should work.

If VM is deployed fine then we add virtual_machine to self.cleanup. Test failed in this situation as VM shouldn't be deployed with wrong checksum of the template.
If VM deployment failed then we delete VMs using template_id because though the API returned error VM entry can still be there in the Error state. I wanted to use self.cleanup.append(VirtualMachine(virtual_machine_response.__dict__) but it wasn't working for me.

yadvr · 2023-10-17T11:24:47Z

@blueorangutan test

blueorangutan · 2023-10-17T11:28:09Z

@rohityadavcloud a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

weizhouapache

code lgtm

shwstppr · 2023-10-19T04:18:59Z

@blueorangutan package

blueorangutan · 2023-10-19T04:20:05Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-10-19T05:18:27Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7428

shwstppr · 2023-10-19T05:19:37Z

@blueorangutan test

blueorangutan · 2023-10-19T05:20:03Z

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-10-19T16:42:48Z

[SF] Trillian test result (tid-8002)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39527 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8096-t8002-kvm-centos7.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

* marvin,test: fix directdownload template checksum test During failure while deploying a VM with wrong checksum template, VM may be left in Error state. This PR adds code to delete such VM. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * remove unnecessary logs --------- Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> (cherry picked from commit a2ec1f3) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

marvin,test: fix directdownload template checksum test
7512f7e
During failure while deploying a VM with wrong checksum template, VM may be left in Error state. This PR adds code to delete such VM. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

boring-cyborgBot added component:integration-test component:marvin Python Warning... Python code Ahead! labels Oct 14, 2023

remove unnecessary logs
60f00d1

yadvr approved these changes Oct 16, 2023
View reviewed changes

yadvr added this to the 4.18.2.0 milestone Oct 16, 2023

yadvr requested review from DaanHoogland and harikrishna-patnala October 16, 2023 08:03

shwstppr mentioned this pull request Oct 16, 2023
test_templates issue #8079
Closed
13 tasks

DaanHoogland approved these changes Oct 16, 2023
View reviewed changes

shwstppr mentioned this pull request Oct 17, 2023
test: add test for standalone snapshot #8104
Merged
13 tasks

weizhouapache approved these changes Oct 18, 2023
View reviewed changes

weizhouapache merged commit a2ec1f3 into apache:4.18Oct 19, 2023

DaanHoogland deleted the fix-test-template branch October 20, 2023 07:19

Uh oh!

Conversation

shwstppr commented Oct 14, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

shwstppr commented Oct 14, 2023

Uh oh!

blueorangutan commented Oct 14, 2023

Uh oh!

blueorangutan commented Oct 14, 2023

Uh oh!

codecovBot commented Oct 14, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shwstppr commented Oct 15, 2023

Uh oh!

blueorangutan commented Oct 15, 2023

Uh oh!

blueorangutan commented Oct 15, 2023

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented Oct 16, 2023

Uh oh!

blueorangutan commented Oct 16, 2023

Uh oh!

blueorangutan commented Oct 16, 2023

Uh oh!

shwstppr commented Oct 16, 2023

Uh oh!

blueorangutan commented Oct 16, 2023

Uh oh!

blueorangutan commented Oct 16, 2023

Uh oh!

DaanHoogland commented Oct 16, 2023

Uh oh!

blueorangutan commented Oct 16, 2023

Uh oh!

DaanHooglandOct 16, 2023

Choose a reason for hiding this comment

Uh oh!

shwstpprOct 16, 2023

Choose a reason for hiding this comment

Uh oh!

yadvr commented Oct 17, 2023

Uh oh!

blueorangutan commented Oct 17, 2023

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Oct 19, 2023

Uh oh!

blueorangutan commented Oct 19, 2023

Uh oh!

blueorangutan commented Oct 19, 2023

Uh oh!

shwstppr commented Oct 19, 2023

Uh oh!

blueorangutan commented Oct 19, 2023

Uh oh!

blueorangutan commented Oct 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

shwstppr commented Oct 14, 2023•
edited
Loading

codecovBot commented Oct 14, 2023•
edited
Loading