test: add test for standalone snapshot by shwstppr · Pull Request #8104 · apache/cloudstack

shwstppr · 2023-10-16T13:01:34Z

Description

Fixes#8034

Adds the following test for a backed-up snapshot (original template and VM deleted beforehand):

Create volume from snapshot
Create a template from the snapshot and deploy a VM using it

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Fixesapache#8034 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2023-10-16T13:09:39Z

@blueorangutan package

blueorangutan · 2023-10-16T13:16:03Z

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

DaanHoogland

clgtm

DaanHoogland · 2023-10-16T13:21:46Z

ui build fails with

npm ERR! This is an error with npm itself. Please report this error at:
npm ERR! <https://npm.community/>
npm ERR! A complete log of this run can be found in:
npm ERR! /home/runner/.npm/_logs/2023-10-16T13_06_23_305Z-debug.log

I didn´t see this one before, but might mean we need to upgrade npm??? cc @rohityadavcloud ?

codecov · 2023-10-16T13:40:43Z

Codecov Report

Merging #8104 (6f05ed6) into 4.18 (3e7f21a) will increase coverage by 15.51%.
Report is 6 commits behind head on 4.18.
The diff coverage is n/a.

@@ Coverage Diff @@## 4.18 #8104 +/- ##
=============================================
+ Coverage 13.06% 28.57% +15.51% - Complexity 9109 31199 +22090 
=============================================
Files 2720 5101 +2381 Lines 257526 379527 +122001 Branches 40150 61382 +21232 =============================================
+ Hits 33655 108465 +74810 - Misses 219644 256120 +36476 - Partials 4227 14942 +10715

Flag	Coverage Δ
simulator-marvin-tests	`25.24% <ø> (?)`
uitests	`4.84% <ø> (?)`
unit-tests	`14.49% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3670 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

blueorangutan · 2023-10-16T14:18:07Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7386

DaanHoogland · 2023-10-16T14:23:03Z

@blueorangutan test

blueorangutan · 2023-10-16T14:24:04Z

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-10-17T04:30:07Z

[SF] Trillian test result (tid-7983)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49266 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8104-t7983-kvm-centos7.zip
Smoke tests completed. 111 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_upgrade_kubernetes_cluster	`Failure`	576.50	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	623.90	test_kubernetes_clusters.py
test_03_deploy_vm_wrong_checksum	`Error`	40.70	test_templates.py
test_09_list_templates_download_details	`Failure`	0.05	test_templates.py

shwstppr · 2023-10-17T06:08:12Z

Template failures are unrelated and have been fixed in #8096

shwstppr · 2023-10-17T11:17:29Z

@blueorangutan package

blueorangutan · 2023-10-17T11:18:03Z

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

yadvr

LGTM thanks @shwstppr for adding test case

borisstoyanov · 2023-10-17T12:04:49Z

@blueorangutan test

borisstoyanov

code LGTM, let's wait for test results

shwstppr · 2023-10-18T06:39:47Z

@blueorangutan package

blueorangutan · 2023-10-18T06:40:04Z

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-10-18T07:42:39Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7410

shwstppr · 2023-10-18T07:55:52Z

@blueorangutan test

blueorangutan · 2023-10-18T07:58:03Z

@shwstppr a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

weizhouapache

code lgtm

blueorangutan · 2023-10-18T20:56:14Z

[SF] Trillian test result (tid-7996)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45074 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8104-t7996-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_vm_wrong_checksum	`Error`	40.61	test_templates.py
test_09_list_templates_download_details	`Failure`	0.04	test_templates.py

shwstppr · 2023-10-19T04:17:44Z

Merging this based on the test results

Fixesapache#8034 Adds the following test for a backed-up snapshot (original template and VM deleted beforehand): - Create volume from snapshot - Create a template from the snapshot and deploy a VM using it Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> (cherry picked from commit 540c7b8) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

test: add test for standalone snapshot
6f05ed6
Fixesapache#8034 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

boring-cyborgBot added component:integration-test Python Warning... Python code Ahead! labels Oct 16, 2023

DaanHoogland approved these changes Oct 16, 2023
View reviewed changes

shwstppr closed this Oct 16, 2023

shwstppr reopened this Oct 16, 2023

shwstppr requested review from harikrishna-patnala, weizhouapache and yadvr October 17, 2023 06:09

shwstppr changed the base branch from main to 4.18October 17, 2023 11:16

shwstppr closed this Oct 17, 2023

shwstppr reopened this Oct 17, 2023

yadvr approved these changes Oct 17, 2023
View reviewed changes

yadvr added this to the 4.18.2.0 milestone Oct 17, 2023

borisstoyanov approved these changes Oct 17, 2023
View reviewed changes

weizhouapache approved these changes Oct 18, 2023
View reviewed changes

shwstppr merged commit 540c7b8 into apache:4.18Oct 19, 2023

shwstppr mentioned this pull request Oct 19, 2023
KVM volume snapshots are not full snapshots anymore #8034
Closed

Uh oh!

Conversation

shwstppr commented Oct 16, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

shwstppr commented Oct 16, 2023

Uh oh!

blueorangutan commented Oct 16, 2023

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Oct 16, 2023

Uh oh!

codecovBot commented Oct 16, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Oct 16, 2023

Uh oh!

DaanHoogland commented Oct 16, 2023

Uh oh!

blueorangutan commented Oct 16, 2023

Uh oh!

blueorangutan commented Oct 17, 2023

Uh oh!

shwstppr commented Oct 17, 2023

Uh oh!

shwstppr commented Oct 17, 2023

Uh oh!

blueorangutan commented Oct 17, 2023

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

borisstoyanov commented Oct 17, 2023

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Oct 18, 2023

Uh oh!

blueorangutan commented Oct 18, 2023

Uh oh!

blueorangutan commented Oct 18, 2023

Uh oh!

shwstppr commented Oct 18, 2023

Uh oh!

blueorangutan commented Oct 18, 2023

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Oct 18, 2023

Uh oh!

shwstppr commented Oct 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

shwstppr commented Oct 16, 2023•
edited
Loading

codecovBot commented Oct 16, 2023•
edited
Loading