Fixed src datastore on copy check for PowerFlex/ScaleIO storage driver

[sureshanaparti]

Description

This PR fixes src datastore on copy check for PowerFlex/ScaleIO storage driver.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested volume migration from pool NFS -> PowerFlex and PowerFlex -> PowerFlex. NFS -> PowerFlex fails with not suitable error.

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[slavkap]

code LGTM

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 12.24%. Comparing base (6b25ed7) to head (36356cd).

Files	Patch %	Lines
...atastore/driver/ScaleIOPrimaryDataStoreDriver.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## 4.18 #9310 +/- ##
============================================
- Coverage 12.24% 12.24% -0.01% + Complexity 9296 9294 -2 
============================================
Files 4699 4699 Lines 414339 414339 Branches 53023 53311 +288 ============================================
- Hits 50731 50727 -4 - Misses 357303 357308 +5 + Partials 6305 6304 -1 

Flag	Coverage Δ
unittests	12.24% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10187

[vishesh92]

clgtm