chore: Improvements of fallback info - #2450
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2450 +/- ##
============================================
+ Coverage 56.12% 58.06% +1.93%
- Complexity 976 1401 +425
============================================
Files 119 146 +27
Lines 11743 13466 +1723
Branches 2251 2342 +91
============================================
+ Hits 6591 7819 +1228
- Misses 4012 4413 +401
- Partials 1140 1234 +94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks @wForget! I'm sure this will be helpful for everyone trying to understand how to get more Comet plans running natively. Do you have a before/after example of the output? |
|
@mbutrovich @andygrove Thank you for your review, and sorry for missing the This improvements come from two unexpected checks in the failing CometExpressionSuite.'explain comet' test case: datafusion-comet/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala Lines 1934 to 1936 in a806bf0
After this fix, these checks work as expected |
Which issue does this PR close?
Closes #2449.
Rationale for this change
Some improvements of fallback info:
CometSparkRowToColumnar:CometSparkRowToColumnar is not supportedReusedExchangeExecwill break the children extended InfosWhat changes are included in this PR?
How are these changes tested?