Skip to content

chore: Make CometColumnarToRowExec extends CometPlan - #2460

Merged
comphead merged 1 commit into
apache:mainfrom
wForget:minor
Sep 29, 2025
Merged

comphead merged 1 commit into
apache:mainfrom
wForget:minor

Conversation

@wForget

@wForget wForget commented Sep 26, 2025

Copy link
Copy Markdown
Member

Which issue does this PR close?

Closes #.

Rationale for this change

I still see the CometColumnarToRow is not supported fallback reason after #2450, which is not what I expected.

- DPP fallback *** FAILED *** (1 second, 561 milliseconds)
  "CometColumnarToRow is not supported" did not contain "Dynamic Partition Pruning is not supported" (CometExecSuite.scala:120)

What changes are included in this PR?

Make CometColumnarToRowExec extends CometPlan

How are these changes tested?

Test the abnormal case locally, before this:

"CometColumnarToRow is not supported" did not contain "Dynamic Partition Pruning is not supported"
ScalaTestFailureLocation: org.apache.comet.exec.CometExecSuite at (CometExecSuite.scala:120)
org.scalatest.exceptions.TestFailedException: "CometColumnarToRow is not supported" did not contain "Dynamic Partition Pruning is not supported"
	at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)

after this:

"" did not contain "Dynamic Partition Pruning is not supported"
ScalaTestFailureLocation: org.apache.comet.exec.CometExecSuite at (CometExecSuite.scala:120)
org.scalatest.exceptions.TestFailedException: "" did not contain "Dynamic Partition Pruning is not supported"
	at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)

@codecov-commenter

codecov-commenter commented Sep 26, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.49%. Comparing base (f09f8af) to head (c9c9f72).
⚠️ Report is 1167 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2460      +/-   ##
============================================
+ Coverage     56.12%   58.49%   +2.36%     
- Complexity      976     1440     +464     
============================================
  Files           119      146      +27     
  Lines         11743    13507    +1764     
  Branches       2251     2349      +98     
============================================
+ Hits           6591     7901    +1310     
- Misses         4012     4375     +363     
- Partials       1140     1231      +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@comphead
comphead merged commit 2512b1a into apache:main Sep 29, 2025
137 of 138 checks passed
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants