Uh oh!
There was an error while loading. Please reload this page.
Adds support for PostgreSQL "END" - #1035
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 6938222562
💛 - Coveralls |
alamb
approved these changes
Nov 20, 2023
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Toby Hede <toby@cipherstash.com>
tobyhedeforce-pushed
the
fix/postgres-end
branch
from
November 21, 2023 01:17
e2101a0 to
9895067CompareSigned-off-by: Toby Hede <toby@cipherstash.com>
tobyhedeforce-pushed
the
fix/postgres-end
branch
from
November 21, 2023 01:59
9895067 to
5f26140Comparealamb
commented
Nov 21, 2023
Contributor
Thanks again @tobyhede |
serprex added a commit
to PeerDB-io/sqlparser-rs
that referenced
this pull request
Dec 11, 2023
Merge 0.40 + apache/datafusion-sqlparser-rs#1040 Upstream implemented END parsing as COMMIT on postgresql: apache/datafusion-sqlparser-rs#1035 allowing some convergence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1034
Adds support for treating
ENDasCOMMIT.END is still used as a statement delimiter, but we only check this case if expecting a statement to end.
I am not 100% sure this is the right approach, but the tests pass.