Uh oh!
There was an error while loading. Please reload this page.
Update sqlparser-derive to use syn 2.0 - #1040
Conversation
tobyhede
commented
Nov 14, 2023
@serprex Some more context on this change would be useful ... I assume it is updating syn? |
serprex
commented
Nov 14, 2023
Yes |
Uh oh!
There was an error while loading. Please reload this page.
alamb
commented
Nov 18, 2023
Thank you for this contribution @serprex |
Pull Request Test Coverage Report for Build 7009097570
💛 - Coveralls |
serprex
commented
Nov 18, 2023
Won't have time this weekend to look into, but will look at how to run tests & fix next week (I only ran |
alamb
commented
Nov 20, 2023
Thanks @serprex . Converting to a draft while review feedback is being addressed. Please mark it ready for review when it is ready for another look |
syn 2.0syn 2.0alamb
commented
Nov 27, 2023
Given I think this may be a non trivial change, I plan to merge this immediately after #1030 Then this PR will have maximum "bake time" for early adopters and others to try it out before I release it on crates.io |
| [dependencies] | ||
| syn = "1.0" | ||
| syn = { version = "2.0", default-features = false, features = ["printing", "parsing", "derive", "proc-macro"] } |
There was a problem hiding this comment.
It seems according to
https://docs.rs/syn/latest/syn/index.html#optional-features
Listing these 4 will at least avoid
clone-impls (enabled by default) — Clone impls for all syntax tree types.
alamb
commented
Nov 27, 2023
Merge 0.40 + apache/datafusion-sqlparser-rs#1040 Upstream implemented END parsing as COMMIT on postgresql: apache/datafusion-sqlparser-rs#1035 allowing some convergence
https://github.com/dtolnay/syn/releases/tag/2.0.0