Skip to content

Add support for Snowflake SHOW DATABASES/SCHEMAS/TABLES/VIEWS/COLUMNS statements - #1501

Merged
alamb merged 6 commits into
apache:mainfrom
yoavcloud:snowflake_show
Nov 13, 2024
Merged

Add support for Snowflake SHOW DATABASES/SCHEMAS/TABLES/VIEWS/COLUMNS statements#1501
alamb merged 6 commits into
apache:mainfrom
yoavcloud:snowflake_show

Conversation

@yoavcloud

@yoavcloudyoavcloud commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

This PR extends the existing support for SHOW statements to Snowflake

@yoavcloud
yoavcloudforce-pushed the snowflake_show branch 2 times, most recently from 991298d to 85901b5CompareNovember 6, 2024 17:47
iffyio
iffyio reviewed Nov 8, 2024
View reviewed changes
Comment threadsrc/parser/mod.rs Outdated
Comment threadsrc/ast/mod.rs
Comment threadsrc/ast/mod.rs Outdated
Comment threadsrc/ast/mod.rs Outdated
Comment threadsrc/ast/mod.rs Outdated
Comment threadsrc/parser/mod.rs Outdated
Comment threadsrc/parser/mod.rs Outdated
Comment threadsrc/parser/mod.rs Outdated
Comment threadsrc/parser/mod.rs Outdated
Comment threadsrc/parser/mod.rs Outdated
@yoavcloud
yoavcloud requested a review from iffyioNovember 9, 2024 18:05
@yoavcloud

yoavcloud commented Nov 9, 2024

Copy link
Copy Markdown
ContributorAuthor

@iffyio thanks for the great comments, it really helped me improve this code. New commit for you to look at.

iffyio
iffyio reviewed Nov 10, 2024
View reviewed changes

@iffyioiffyio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, mostly small I think, the only one unclear to me was the mysql object_name insert behavior. I think this looks good overall, Thanks @yoavcloud!

Comment threadsrc/ast/mod.rs Outdated
Comment threadsrc/parser/mod.rs Outdated
Comment threadsrc/parser/mod.rs Outdated
Comment threadsrc/parser/mod.rs Outdated
Comment threadsrc/parser/mod.rs Outdated
Comment threadsrc/parser/mod.rs
Comment threadtests/sqlparser_snowflake.rs
Comment threadsrc/ast/mod.rs
iffyio
iffyio reviewed Nov 12, 2024
View reviewed changes
Comment threadsrc/dialect/mod.rs Outdated
false
}

/// Returns true if this dialect support the `LIKE 'pattern'` option in

@iffyioiffyioNov 12, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Returns true if this dialect support the `LIKE 'pattern'` option in
/// Returns true if this dialect supports the `LIKE 'pattern'` option in

Comment threadsrc/parser/mod.rs Outdated
Comment threadsrc/parser/mod.rs
Comment threadtests/sqlparser_snowflake.rs
iffyio
iffyio reviewed Nov 12, 2024
View reviewed changes
Comment threadsrc/ast/mod.rs
iffyio
iffyio approved these changes Nov 13, 2024
View reviewed changes

@iffyioiffyio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @alamb

@alamb

alamb commented Nov 13, 2024

Copy link
Copy Markdown
Contributor

🚀

@alamb
alamb merged commit 76322ba into apache:mainNov 13, 2024
@alamb

alamb commented Nov 13, 2024

Copy link
Copy Markdown
Contributor

Thanks again @iffyio and @yoavcloud

@goldmedalgoldmedal mentioned this pull request Nov 26, 2024
Closed
@alambalamb mentioned this pull request Nov 26, 2024
Closed
@alamb

alamb commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

We think this may have introduced a small regression:

@alambalamb mentioned this pull request Dec 20, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iffyioiffyioiffyio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yoavcloud@alamb@iffyio