Uh oh!
There was an error while loading. Please reload this page.
Support full SHOW TABLES syntax - #563
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 2839397720Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
MazterQyouforce-pushed
the
upstream-patch/show-tables
branch
2 times, most recently
from
August 9, 2022 15:59
a6a1e74 to
59c37e9Comparealamb
approved these changes
Aug 11, 2022
| self.expect_one_of_keywords(&[Keyword::COLUMNS, Keyword::FIELDS])?; | ||
| pub fn parse_show_columns( | ||
| &mut self, | ||
| extended: bool, |
Contributor
There was a problem hiding this comment.
👍 nice refactoring of this into the common parse_show
| assert!(mysql_and_generic() | ||
| .parse_sql_statements("SHOW EXTENDED FULL COLUMNS FROM mytable") | ||
| .is_ok()); | ||
| // SHOW EXTENDED/FULL can only be used with COLUMNS and TABLES |
| table_name: ObjectName, | ||
| filter: Option<ShowStatementFilter>, | ||
| }, | ||
| /// SHOW TABLES |
Contributor
There was a problem hiding this comment.
I reviewed and this appears to match https://dev.mysql.com/doc/refman/8.0/en/show-tables.html
alamb
commented
Aug 11, 2022
Contributor
@MazterQyou -- github says this PR has a conflict that needs to be resolved. Can you please merge up from master so I can then merge it in? Thank you |
alamb
marked this pull request as draft
August 11, 2022 11:01
alamb
marked this pull request as ready for review
August 11, 2022 11:01
MazterQyouforce-pushed
the
upstream-patch/show-tables
branch
from
August 11, 2022 11:19
59c37e9 to
11d68abCompareMazterQyou
commented
Aug 11, 2022
ContributorAuthor
@alamb rebased the PR branch to resolve the conflict 👌 |
Merged
alamb
commented
Aug 11, 2022
Contributor
Thanks @MazterQyou ! |
mcheshkov pushed a commit
to cube-js/sqlparser-rs
that referenced
this pull request
Sep 2, 2024
Can drop this after rebase on commit b6e36ad "Support SHOW TABLES (apache#563)", first released in 0.21.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for MySQL-specific
SHOW TABLESstatement with full syntax support, as well as a related test.