Skip to content

Support SHOW COLLATION - #564

Merged
alamb merged 1 commit into
apache:mainfrom
cube-js:upstream-patch/show-collation
Aug 11, 2022
Merged

Support SHOW COLLATION#564
alamb merged 1 commit into
apache:mainfrom
cube-js:upstream-patch/show-collation

Conversation

@MazterQyou

Copy link
Copy Markdown
Contributor

This PR adds support for MySQL-specific SHOW COLLATION statement with full syntax support, as well as a related test.

@coveralls

coveralls commented Aug 9, 2022

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 2840047609

  • 24 of 24(100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 89.981%

TotalsCoverage Status
Change from base Build 2839791289:0.02%
Covered Lines:9313
Relevant Lines:10350

💛 - Coveralls

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks @MazterQyou

@alamb

Copy link
Copy Markdown
Contributor

@MazterQyou -- github shows that this PR has conflicts that must be resolved (likely with #559) -- can you please resolve them (probably needs a merge from main)

@alamb
alamb marked this pull request as draft August 11, 2022 10:45
@alamb
alamb marked this pull request as ready for review August 11, 2022 11:02
@MazterQyou

Copy link
Copy Markdown
ContributorAuthor

This PR is almost guaranteed to conflict with #563 so I'll wait for that to be merged first, then rebase.

@alamb

Copy link
Copy Markdown
Contributor

#563 has been merged

@MazterQyou
MazterQyouforce-pushed the upstream-patch/show-collation branch from cc29d03 to bb34268CompareAugust 11, 2022 13:14
@MazterQyou

Copy link
Copy Markdown
ContributorAuthor

@alamb rebased the PR branch and also extended another test in sqlparser_mysql.rs, please re-review.

@MazterQyou
MazterQyou requested a review from alambAugust 11, 2022 13:17

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alamb
alamb merged commit 18881f8 into apache:mainAug 11, 2022
@MazterQyou
MazterQyou deleted the upstream-patch/show-collation branch August 11, 2022 13:50
mcheshkov pushed a commit to cube-js/sqlparser-rs that referenced this pull request Sep 2, 2024
Can drop this after rebase on commit 18881f8 "Support SHOW COLLATION (apache#564)", first released in 0.21.0
mcheshkov pushed a commit to cube-js/sqlparser-rs that referenced this pull request Sep 3, 2024
Can drop this after rebase on commit 18881f8 "Support SHOW COLLATION (apache#564)", first released in 0.21.0
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MazterQyou@coveralls@alamb