Skip to content

Remove Box from Sort - #12207

Merged
lewiszlw merged 1 commit into
apache:mainfrom
findepi:findepi/remove-sort-box
Aug 30, 2024
Merged

Remove Box from Sort #12207
lewiszlw merged 1 commit into
apache:mainfrom
findepi:findepi/remove-sort-box

Conversation

@findepi

@findepifindepi commented Aug 28, 2024•
edited
Loading

Copy link
Copy Markdown
Member

expr::Sort had Box<Expr> because Sort was also an expression (via
expr::Expr::Sort). This has been removed, obsoleting need to use a
Box.

Extracted from and based on#12177 to reduce PR scope

@findepi
findepi marked this pull request as draft August 28, 2024 07:25
@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation sql SQL Planner logical-expr Logical plan and expressions optimizer Optimizer rules core Core DataFusion crate substrait Changes to the substrait crate proto Related to proto crate functions Changes to functions implementation labels Aug 28, 2024
@findepi
Remove Box from Sort
03d6167
`expr::Sort` had `Box<Expr>` because Sort was also an expression (via
`expr::Expr::Sort`). This has been removed, obsoleting need to use a
`Box`.
@findepi
findepiforce-pushed the findepi/remove-sort-box branch from 9840b8f to 03d6167CompareAugust 29, 2024 15:57
@findepi
findepi marked this pull request as ready for review August 29, 2024 15:57
@github-actionsgithub-actionsBot removed documentation Improvements or additions to documentation functions Changes to functions implementation labels Aug 29, 2024
@findepi

findepi commented Aug 29, 2024

Copy link
Copy Markdown
MemberAuthor

thanks again @crepererum for merging #12177
this PR is now rebased on current main and ready for review

crepererum
crepererum approved these changes Aug 29, 2024
View reviewed changes

@crepererumcrepererum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me.

@crepererumcrepererum added the api change Changes the API exposed to users of the crate label Aug 29, 2024
@findepifindepi mentioned this pull request Aug 29, 2024
Closed
lewiszlw
lewiszlw approved these changes Aug 30, 2024
View reviewed changes

@lewiszlwlewiszlw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense, thank you @findepi .

@lewiszlw
lewiszlw merged commit 94d178e into apache:mainAug 30, 2024
@findepi
findepi deleted the findepi/remove-sort-box branch August 30, 2024 09:46
@findepi

findepi commented Aug 30, 2024

Copy link
Copy Markdown
MemberAuthor

thank you @crepererum@lewiszlw for your reviews!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crepererumcrepererumcrepererum approved these changes
@lewiszlwlewiszlwlewiszlw approved these changes

Assignees

No one assigned

Labels

api changeChanges the API exposed to users of the cratecoreCore DataFusion cratelogical-exprLogical plan and expressionsoptimizerOptimizer rulesprotoRelated to proto cratesqlSQL PlannersubstraitChanges to the substrait crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@findepi@crepererum@lewiszlw