Uh oh!
There was an error while loading. Please reload this page.
Enable needless_pass_by_value clippy lint - #12243
Closed
findepi wants to merge 1 commit into
Closed
Conversation
findepi
marked this pull request as draft
August 29, 2024 21:05
findepi
commented
Aug 29, 2024
MemberAuthor
findepi
commented
Aug 29, 2024
MemberAuthor
cc @crepererum |
findepiforce-pushed
the
findepi/needless_pass_by_value
branch
from
August 29, 2024 21:06
6528d96 to
731b64bComparecrepererum
commented
Aug 30, 2024
Contributor
could you try to factor out the API changes into separate PRs? This would make the reviews and the changelog generation a bit easier. |
findepiforce-pushed
the
findepi/needless_pass_by_value
branch
from
August 30, 2024 11:37
731b64b to
69bc660Compare
This was referenced Aug 30, 2024
findepiforce-pushed
the
findepi/needless_pass_by_value
branch
from
August 30, 2024 13:03
69bc660 to
978f0b5Comparefindepi
commented
Aug 30, 2024
MemberAuthor
good call! extracted these for now |
findepiforce-pushed
the
findepi/needless_pass_by_value
branch
from
September 6, 2024 18:50
978f0b5 to
59d0bcdCompareThank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #12197 (comment)