Skip to content

Apply clippy fixes for Rust 1.83 - #13596

Merged
jonahgao merged 4 commits into
apache:mainfrom
findepi:findepi/apply-clippy-fixes-e2c260
Nov 29, 2024
Merged

Apply clippy fixes for Rust 1.83#13596
jonahgao merged 4 commits into
apache:mainfrom
findepi:findepi/apply-clippy-fixes-e2c260

Conversation

@findepi

@findepifindepi commented Nov 28, 2024•
edited
Loading

Copy link
Copy Markdown
Member

dev/rust_lint.sh no longer passes for me, maybe because of rustup update. This is first portion of fixes suggested by clippy.

@github-actionsgithub-actionsBot added sql SQL Planner physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate common Related to common crate functions Changes to functions implementation labels Nov 28, 2024
@findepi
findepiforce-pushed the findepi/apply-clippy-fixes-e2c260 branch from cecf231 to 95acf32CompareNovember 28, 2024 18:55
@github-actionsgithub-actionsBot added logical-expr Logical plan and expressions execution Related to the execution crate labels Nov 28, 2024
@findepifindepi changed the title Apply clippy fixesApply clippy fixes for Rust 1.83Nov 28, 2024
@github-actionsgithub-actionsBot added the catalog Related to the catalog crate label Nov 28, 2024
comphead
comphead reviewed Nov 28, 2024
View reviewed changes

@compheadcomphead left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @findepi
Please help with the comments

Comment threaddatafusion/expr-common/src/type_coercion/aggregates.rs
Comment threaddatafusion/expr/src/logical_plan/display.rs
Comment threaddatafusion/functions-nested/src/concat.rs Outdated
Comment threaddatafusion/optimizer/src/replace_distinct_aggregate.rs
Comment threaddatafusion/physical-plan/src/sorts/sort_preserving_merge.rs
@comphead

comphead commented Nov 28, 2024

Copy link
Copy Markdown
Contributor

I think we need to #allow[missing_docs] as the clippy now complains on that

@findepi

findepi commented Nov 28, 2024

Copy link
Copy Markdown
MemberAuthor

I think we need to #allow[missing_docs] as the clippy now complains on that

:) just added

@findepi

findepi commented Nov 28, 2024

Copy link
Copy Markdown
MemberAuthor

now that #13598 is merged, let be rebase, otherwise we no longer test with 1.83

findepiand others added 4 commits November 28, 2024 21:41
@findepi
Apply clippy fixes
f1287ef
`dev/rust_lint.sh` no longer passes for me, maybe because of `rustup
update`. This is first portion of fixes suggested by clippy.
@Dandandan@comphead@findepi
Fix typo
d984ae2
Co-authored-by: Oleks V <comphead@users.noreply.github.com>
@findepi
Suppress missing docs clippy check in test code
0c8d919
@findepi
Revert "Temporarily pin toolchain version to avoid clippy (apache#13598…
d0a5e5f
…)"
This reverts commit 2b37018.
Toolchain pinning is no longer needed.
@findepi
findepiforce-pushed the findepi/apply-clippy-fixes-e2c260 branch from fee0d90 to d0a5e5fCompareNovember 28, 2024 20:41
@findepi

findepi commented Nov 28, 2024

Copy link
Copy Markdown
MemberAuthor

clippy job passed with toolchain pin dropped.

comphead
comphead approved these changes Nov 28, 2024
View reviewed changes

@compheadcomphead left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @findepi

@jonahgao
jonahgao merged commit 703b10d into apache:mainNov 29, 2024
@jonahgao

jonahgao commented Nov 29, 2024

Copy link
Copy Markdown
Member

Thanks @findepi@comphead@Dandandan

@findepi
findepi deleted the findepi/apply-clippy-fixes-e2c260 branch November 29, 2024 08:15
@alambalamb mentioned this pull request Feb 13, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DandandanDandandanDandandan left review comments
@compheadcompheadcomphead approved these changes

Assignees

No one assigned

Labels

catalogRelated to the catalog cratecommonRelated to common cratecoreCore DataFusion crateexecutionRelated to the execution cratefunctionsChanges to functions implementationlogical-exprLogical plan and expressionsoptimizerOptimizer rulesphysical-exprChanges to the physical-expr cratessqlSQL Planner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix build issues on latest stable Rust toolchain (1.83)

4 participants

@findepi@comphead@jonahgao@Dandandan