Uh oh!
There was an error while loading. Please reload this page.
Temporarily pin toolchain version to avoid clippy - #13598
Merged
Dandandan merged 1 commit intoNov 28, 2024
Merged
Conversation
Temporarily pin toolchain version until problems reported by newer clippy release are solved.
findepi
commented
Nov 28, 2024
MemberAuthor
cc @Dandandan@alamb let's maybe merge this in, since the PR builds already started to fail -- #13595 (comment) |
Dandandan
approved these changes
Nov 28, 2024
findepi
deleted the
findepi/temporarily-pin-toolchain-version-to-avoid-clippy-4acc89
branch
November 28, 2024 20:39
findepi
commented
Nov 28, 2024
MemberAuthor
thanks for the merge! |
findepi added a commit
to findepi/datafusion
that referenced
this pull request
Nov 28, 2024
…)" This reverts commit 2b37018. Toolchain pinning is no longer needed.
jonahgao pushed a commit
that referenced
this pull request
Nov 29, 2024
* Apply clippy fixes `dev/rust_lint.sh` no longer passes for me, maybe because of `rustup update`. This is first portion of fixes suggested by clippy. * Fix typo Co-authored-by: Oleks V <comphead@users.noreply.github.com> * Suppress missing docs clippy check in test code * Revert "Temporarily pin toolchain version to avoid clippy (#13598)" This reverts commit 2b37018. Toolchain pinning is no longer needed. --------- Co-authored-by: Daniël Heres <danielheres@gmail.com> Co-authored-by: Oleks V <comphead@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporarily pin toolchain version until problems reported by newer clippy release are solved.