Uh oh!
There was an error while loading. Please reload this page.
refactor: remove remaining uses of arrow_array and use reexport in arrow instead - #14528
Merged
alamb merged 8 commits intoFeb 8, 2025
Merged
Conversation
Chen-Yuan-Laiforce-pushed
the
use_reexport_in_arrow_instead_of_arrow_array
branch
from
February 7, 2025 01:49
78f7847 to
4bd8dacCompare
Chen-Yuan-Laiforce-pushed
the
use_reexport_in_arrow_instead_of_arrow_array
branch
from
February 7, 2025 01:57
4bd8dac to
327bc78Comparealamb
approved these changes
Feb 7, 2025
alamb
left a comment
Contributor
There was a problem hiding this comment.
A very nice simplification @Chen-Yuan-Lai -- thank you 🙏
| arrow = { workspace = true } | ||
| arrow-array = { workspace = true } | ||
| arrow-ipc = { workspace = true } | ||
| arrow-schema = { workspace = true } |
Contributor
There was a problem hiding this comment.
Hmm, looks like there is one PR left -- arrow-schema 🤔
Any chance you want another fun cleanup PR @Chen-Yuan-Lai :)
…_instead_of_arrow_array
alamb
commented
Feb 8, 2025
Contributor
Thanks again @Chen-Yuan-Lai |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
NullBufferBuilderinstead ofBooleanBufferBuilderfor creating Null masks #14115.Rationale for this change
As #14503 (review) says,
arrow_arrayshould be removed and be replaced with reexport in arrow as much as possible.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?