Uh oh!
There was an error while loading. Please reload this page.
refactor: remove uses of arrow_schema and use reexport in arrow instead - #14597
Merged
alamb merged 4 commits intoFeb 11, 2025
Merged
Conversation
Chen-Yuan-Laiforce-pushed
the
use_reexport_in_arrow_instead_of_arrow_schema
branch
from
February 11, 2025 05:24
be33471 to
c7248faCompareChen-Yuan-Lai
commented
Feb 11, 2025
ContributorAuthor
Due to some uses of |
alamb
approved these changes
Feb 11, 2025
Contributor
There was a problem hiding this comment.
Thank you @Chen-Yuan-Lai -- this is a great PR ❤️
This was referenced Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
NullBufferBuilderinstead ofBooleanBufferBuilderfor creating Null masks #14115.Rationale for this change
What changes are included in this PR?
As #14528 (comment) says, arrow_schema should be removed and be replaced with reexport in arrow as much as possible.
Are these changes tested?
Are there any user-facing changes?