Uh oh!
There was an error while loading. Please reload this page.
Remove Accumulator::update and Accumulator::merge - #1582
Merged
Conversation
jimexistforce-pushed
the
remove-update-merge
branch
2 times, most recently
from
January 16, 2022 10:23
a5c1c70 to
2e2da40Comparealamb
commented
Jan 16, 2022
Contributor
Nice @jimexist -- you beat me to it :) There are a few more instances that need updating -- will see if I can try and help fix it |
jimexistforce-pushed
the
remove-update-merge
branch
from
January 16, 2022 12:54
2e2da40 to
2835eb2Comparejimexist
marked this pull request as ready for review
January 16, 2022 12:54
jimexist
commented
Jan 16, 2022
Uh oh!
There was an error while loading. Please reload this page.
jimexistforce-pushed
the
remove-update-merge
branch
from
January 16, 2022 12:58
cdb36a9 to
603fe41Comparejimexistforce-pushed
the
remove-update-merge
branch
from
January 16, 2022 12:58
603fe41 to
f9f6fe1Comparealamb
reviewed
Jan 16, 2022
Uh oh!
There was an error while loading. Please reload this page.
alamb
reviewed
Jan 16, 2022
Uh oh!
There was an error while loading. Please reload this page.
jimexistforce-pushed
the
remove-update-merge
branch
3 times, most recently
from
January 16, 2022 15:11
88797ea to
0f39d02Comparealamb
approved these changes
Jan 17, 2022
| } | ||
| impl Accumulator for ArrayAggAccumulator { | ||
| fn update_batch(&mut self, values: &[ArrayRef]) -> Result<()> { |
Contributor
There was a problem hiding this comment.
I think it would be a good idea as a follow on PR to update these implementations to avoid the use of ScalarValue.
I'll try find some time this week to do it (I need some coding time :) -- lots of reviewing so far)
MemberAuthor
There was a problem hiding this comment.
let's track this in a GitHub issue
jimexistforce-pushed
the
remove-update-merge
branch
from
January 17, 2022 14:35
0f39d02 to
80d5969Comparealamb
commented
Jan 18, 2022
Contributor
Thanks @jimexist -- this is a great piece of work |
Accumulator::update and Accumulator::merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes#1549
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?