Uh oh!
There was an error while loading. Please reload this page.
refactor array_agg to not to have update and merge - #1681
Merged
Conversation
jimexist
commented
Jan 26, 2022
MemberAuthor
related #1598 |
alamb
approved these changes
Jan 26, 2022
| .map(|array| ScalarValue::try_from_array(array, index)) | ||
| .collect::<Result<Vec<_>>>()?; | ||
| self.update(&v) | ||
| assert!(values.len() == 1, "array_agg can only take 1 param!"); |
alamb
commented
Feb 10, 2022
Contributor
I think the API change was in another PR #1582 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?