Uh oh!
There was an error while loading. Please reload this page.
Bump MSRV to 1.88.0 - #18403
Merged
Merged
Conversation
Update Minimum Supported Rust Version from 1.87.0 to 1.88.0 per MSRV policy. Rust 1.91.0 was released, which allows us to upgrade from 1.87.0 to 1.88.0 following our policy of supporting the last 4 stable Rust minor versions. Closesapache#18395
alamb
reviewed
Oct 31, 2025
| [`1.87.0`]: https://releases.rs/docs/1.87.0/ | ||
| ### `MSRV` updated to 1.88.0 |
Contributor
There was a problem hiding this comment.
@harshasiddartha -- can you please consolidate this entry with the one above (there is no need to say we updated the MSRV from 1.87 and to 1.88)?
Combine the separate 1.87.0 and 1.88.0 MSRV entries into a single entry as requested in review.
harshasiddartha
commented
Oct 31, 2025
ContributorAuthor
Thanks for the review @alamb! I've consolidated the MSRV entries into a single entry as requested. The documentation now only mentions the update to 1.88.0 without referencing the previous version. |
harshasiddartha
commented
Oct 31, 2025
ContributorAuthor
Hi @alamb, I've already consolidated the MSRV entries in commit 1caee69. The documentation now has a single entry for "MSRV updated to 1.88.0" without any reference to version 1.87.0. The old 1.87.0 entry has been completely removed and replaced with the 1.88.0 entry. Please let me know if you're still seeing any references to 1.87.0 in the PR diff view - I can double-check if needed. |
Jefffrey
approved these changes
Nov 1, 2025
harshasiddartha
commented
Nov 1, 2025
ContributorAuthor
@alamb can you review and merge my pr |
alamb
commented
Nov 1, 2025
Contributor
Looks good to me now -- thank you @harshasiddartha and @Jefffrey |
Uh oh!
There was an error while loading. Please reload this page.
tschwarzinger pushed a commit
to tschwarzinger/datafusion
that referenced
this pull request
Nov 2, 2025
## Description This PR bumps the Minimum Supported Rust Version (MSRV) from 1.87.0 to 1.88.0 per our MSRV policy. Rust 1.91.0 was released today: https://blog.rust-lang.org/2025/10/30/Rust-1.91.0/ Per our MSRV policy we can now upgrade from 1.87.0 to 1.88.0. The policy states that DataFusion supports the last 4 stable Rust minor versions released and any such versions released within the last 4 months. ## Changes - Updated `rust-version` in `Cargo.toml` from `1.87.0` to `1.88.0` - Added upgrade note in `docs/source/library-user-guide/upgrading.md` ## Testing - ✅ Verified the code compiles with Rust 1.90.0 (newer than MSRV) - ✅ All workspace crates compile successfully ## Related Closesapache#18395 ## Notes This change enables the use of Rust 1.88.0 features, including let chains, which are now available for use in the codebase.
codetyri0n pushed a commit
to codetyri0n/datafusion
that referenced
this pull request
Nov 11, 2025
## Description This PR bumps the Minimum Supported Rust Version (MSRV) from 1.87.0 to 1.88.0 per our MSRV policy. Rust 1.91.0 was released today: https://blog.rust-lang.org/2025/10/30/Rust-1.91.0/ Per our MSRV policy we can now upgrade from 1.87.0 to 1.88.0. The policy states that DataFusion supports the last 4 stable Rust minor versions released and any such versions released within the last 4 months. ## Changes - Updated `rust-version` in `Cargo.toml` from `1.87.0` to `1.88.0` - Added upgrade note in `docs/source/library-user-guide/upgrading.md` ## Testing - ✅ Verified the code compiles with Rust 1.90.0 (newer than MSRV) - ✅ All workspace crates compile successfully ## Related Closesapache#18395 ## Notes This change enables the use of Rust 1.88.0 features, including let chains, which are now available for use in the codebase.
jayhan94 pushed a commit
to jayhan94/datafusion
that referenced
this pull request
Jul 23, 2026
see previous bump - apache#18403 honestly my main motivation was i was using a feature from `1.89.0` apparently for apache#23631 and realized we hadn't bumped this in a while if we prefer to be more conservative with msrv bumps (i.e. only bump if a dependency requires it or we see a really useful feature/lib function in newer versions) then i'm fine with leaving it and altering my PR above, but in the past we usually kept up to date with bumping our msrv
kosiew pushed a commit
to kosiew/datafusion
that referenced
this pull request
Aug 12, 2026
see previous bump - apache#18403 honestly my main motivation was i was using a feature from `1.89.0` apparently for apache#23631 and realized we hadn't bumped this in a while if we prefer to be more conservative with msrv bumps (i.e. only bump if a dependency requires it or we see a really useful feature/lib function in newer versions) then i'm fine with leaving it and altering my PR above, but in the past we usually kept up to date with bumping our msrv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps the Minimum Supported Rust Version (MSRV) from 1.87.0 to 1.88.0 per our MSRV policy.
Rust 1.91.0 was released today: https://blog.rust-lang.org/2025/10/30/Rust-1.91.0/
Per our MSRV policy we can now upgrade from 1.87.0 to 1.88.0. The policy states that DataFusion supports the last 4 stable Rust minor versions released and any such versions released within the last 4 months.
Changes
rust-versioninCargo.tomlfrom1.87.0to1.88.0docs/source/library-user-guide/upgrading.mdTesting
Related
Closes#18395
Notes
This change enables the use of Rust 1.88.0 features, including let chains, which are now available for use in the codebase.