Uh oh!
There was an error while loading. Please reload this page.
Bump MSRV from 1.88.0 to 1.94.0 - #23632
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #23632 +/- ##
==========================================
- Coverage 80.71% 80.71% -0.01%
==========================================
Files 1089 1089 Lines 368911 368911 Branches 368911 368911 ==========================================
- Hits 297783 297769 -14 - Misses 53373 53385 +12 - Partials 17755 17757 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
neilconway
commented
Jul 16, 2026
Personally I'm okay with bumping MSRV more aggressively, but I don't know if we have a policy on it. |
On discord @Omega359 pointed to https://datafusion.apache.org/user-guide/introduction.html#rust-version-compatibility-policy. Since we're at Rust 1.97, bumping to 1.94 would be in line with the policy of supporting the last 4 stable releases. |
neilconway
commented
Jul 21, 2026
If that's the policy, I'm fine with landing this now -- let me know if anyone feels otherwise. @Jefffrey Can you resolve the merge conflict when you get a chance? |
Uh oh!
There was an error while loading. Please reload this page.
see previous bump - apache#18403 honestly my main motivation was i was using a feature from `1.89.0` apparently for apache#23631 and realized we hadn't bumped this in a while if we prefer to be more conservative with msrv bumps (i.e. only bump if a dependency requires it or we see a really useful feature/lib function in newer versions) then i'm fine with leaving it and altering my PR above, but in the past we usually kept up to date with bumping our msrv
see previous bump
honestly my main motivation was i was using a feature from
1.89.0apparently for #23631 and realized we hadn't bumped this in a whileif we prefer to be more conservative with msrv bumps (i.e. only bump if a dependency requires it or we see a really useful feature/lib function in newer versions) then i'm fine with leaving it and altering my PR above, but in the past we usually kept up to date with bumping our msrv