Skip to content

Bump MSRV from 1.88.0 to 1.94.0 - #23632

Merged
neilconway merged 2 commits into
apache:mainfrom
Jefffrey:bump-msrv
Jul 23, 2026
Merged

Bump MSRV from 1.88.0 to 1.94.0#23632
neilconway merged 2 commits into
apache:mainfrom
Jefffrey:bump-msrv

Conversation

@Jefffrey

Copy link
Copy Markdown
Contributor

see previous bump

honestly my main motivation was i was using a feature from 1.89.0 apparently for #23631 and realized we hadn't bumped this in a while

if we prefer to be more conservative with msrv bumps (i.e. only bump if a dependency requires it or we see a really useful feature/lib function in newer versions) then i'm fine with leaving it and altering my PR above, but in the past we usually kept up to date with bumping our msrv

@github-actionsgithub-actionsBot added the documentation Improvements or additions to documentation label Jul 16, 2026
@JefffreyJefffrey added the api change Changes the API exposed to users of the crate label Jul 16, 2026
@codecov-commenter

codecov-commenter commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.71%. Comparing base (0de74cc) to head (f2a7139).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #23632 +/- ##
==========================================
- Coverage 80.71% 80.71% -0.01% 
==========================================
Files 1089 1089 Lines 368911 368911 Branches 368911 368911 ==========================================
- Hits 297783 297769 -14 - Misses 53373 53385 +12 - Partials 17755 17757 +2 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@neilconway

Copy link
Copy Markdown
Contributor

Personally I'm okay with bumping MSRV more aggressively, but I don't know if we have a policy on it.

@pepijnve

pepijnve commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

On discord @Omega359 pointed to https://datafusion.apache.org/user-guide/introduction.html#rust-version-compatibility-policy. Since we're at Rust 1.97, bumping to 1.94 would be in line with the policy of supporting the last 4 stable releases.

@neilconway

Copy link
Copy Markdown
Contributor

If that's the policy, I'm fine with landing this now -- let me know if anyone feels otherwise.

@Jefffrey Can you resolve the merge conflict when you get a chance?

@neilconway
neilconway enabled auto-merge July 23, 2026 01:45
@neilconway
neilconway added this pull request to the merge queueJul 23, 2026
Merged via the queue into apache:main with commit ba8796eJul 23, 2026
39 checks passed
@Jefffrey
Jefffrey deleted the bump-msrv branch July 23, 2026 04:36
kosiew pushed a commit to kosiew/datafusion that referenced this pull request Aug 12, 2026
see previous bump
- apache#18403
honestly my main motivation was i was using a feature from `1.89.0`
apparently for apache#23631 and
realized we hadn't bumped this in a while
if we prefer to be more conservative with msrv bumps (i.e. only bump if
a dependency requires it or we see a really useful feature/lib function
in newer versions) then i'm fine with leaving it and altering my PR
above, but in the past we usually kept up to date with bumping our msrv
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api changeChanges the API exposed to users of the cratedocumentationImprovements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Jefffrey@codecov-commenter@neilconway@pepijnve