[sql]: remove old deprecated DFParser::new and DFParser::new_with_dialect

[mgkz0]

Which issue does this PR close?

• part of Remove old deprecated code #23080

Rationale for this change

DFParser::new and DFParser::new_with_dialect were deprecated in 46.0.0 and replaced by DFParserBuilder.

What changes are included in this PR?

Removed the deprecated DFParser::new and DFParser::new_with_dialect constructors from datafusion-sql.

Are these changes tested?

Verified by running local tests for datafusion-sql package.

Are there any user-facing changes?

Yes. This removes public Rust APIs DFParser::new and DFParser::new_with_dialect that were deprecated in 46.0.0. Downstream users should migrate to DFParserBuilder.

This is an API change and should be labeled api change.

[github-actions]

Thank you for opening this pull request!

Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).

Details

 Cloning apache/main
Building datafusion-sql v54.0.0 (current)
Built [ 43.974s] (current)
Parsing datafusion-sql v54.0.0 (current)
Parsed [ 0.036s] (current)
Building datafusion-sql v54.0.0 (baseline)
Built [ 44.549s] (baseline)
Parsing datafusion-sql v54.0.0 (baseline)
Parsed [ 0.037s] (baseline)
Checking datafusion-sql v54.0.0 -> v54.0.0 (no change; assume patch)
Checked [ 0.383s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip
--- failure inherent_method_missing: pub method removed or renamed ---
Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/inherent_method_missing.ron
Failed in:
DFParser::new, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/51290a432cda85938bedcd4fdeb7e500782bce90/datafusion/sql/src/parser.rs:508
DFParser::new_with_dialect, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/51290a432cda85938bedcd4fdeb7e500782bce90/datafusion/sql/src/parser.rs:513
Summary semver requires new major version: 1 major and 0 minor checks failed
Finished [ 91.134s] datafusion-sql

[Dodothereal]

@alamb (and any other reviewer) — gentle ping: this is the latest #23080 partial removal, DFParser::new / DFParser::new_with_dialect in datafusion/sql/src/parser.rs (replacement: DFParserBuilder). 13-line deletion, no callsites. CI green. Continuation of the deprecation sweep (#23129, #23131, #23132, #23134, #23135, #23139 — all from this week's batch, mostly landed).

[alamb]

Thank you @megakaizo and @Dodothereal