Uh oh!
There was an error while loading. Please reload this page.
[execution] Remove deprecated disk manager configuration API - #23139
Conversation
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Dodothereal
commented
Jun 23, 2026
@alamb (and any other reviewer) — another #23080 partial removal: |
2010YOUY01
commented
Jun 24, 2026
LGTM, thank you! |
Uh oh!
There was an error while loading. Please reload this page.
Which issue does this PR close?
Rationale for this change
DiskManagerConfigandDiskManager::try_newwere deprecated in version 48.0.0 in favor of the newDiskManagerBuilder. This PR remove this deprecated methods and update Runtime env initialization logicWhat changes are included in this PR?
RuntimeEnvBuilder::with_disk_managerdepercated method.DiskManagerConfigenum and its associated constructor methods.DiskManager::try_newmethod.RuntimeEnvBuilderto storeOption<Arc<DiskManager>>instead of the old configuration enum.RuntimeEnvBuilder::buildlogic by using matching to handle the existing manager, builder, or default initialization.Are these changes tested?
verifed by running local tests
Are there any user-facing changes?
Yes. This removes the deprecated public Rust APIs
RuntimeEnvBuilder::with_disk_manager,DiskManagerConfigandDiskManager::try_new. Downstream users who need to configure the disk manager should migrate to usingDiskManager::builder.This is an API change and should be labeled as
api change.