Uh oh!
There was an error while loading. Please reload this page.
[branch-55] Fix panic on RightMark hash joins when propagating ordering (#24718) - #24759
Merged
timsaucer merged 1 commit intoAug 29, 2026
Merged
Conversation
…4718) ## Which issue does this PR close? - Closesapache#24717 (affecting DF 55) ## Rationale for this change Fixes a panic in `enforce_sorting` when given a `RightMark` hash join: `HashjoinExec::maintains_input_order` has been changed to also return `true` on `RightMark` but `enforce_sorting` has not been updated ## What changes are included in this PR? Adds support of `RightMark` joins to `enforce_sorting` they keep the input sorting.
timsaucer
commented
Aug 28, 2026
MemberAuthor
@Tpt Would you mind reviewing as the original author? It was a trivial cherry pick. |
timsaucer
marked this pull request as ready for review
August 28, 2026 14:45
25 tasks
Tpt
approved these changes
Aug 28, 2026
codecov-commenter
commented
Aug 28, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## branch-55 #24759 +/- ##
=============================================
- Coverage 81.17% 81.17% -0.01%
=============================================
Files 1110 1110 Lines 387043 387043 Branches 387043 387043 =============================================
- Hits 314186 314177 -9 - Misses 54366 54373 +7 - Partials 18491 18493 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
nuno-faria
approved these changes
Aug 28, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a backport of #24718 onto
branch-55for the purpose of a patch release.