chore: mark partial reduce stream as can handle back pressure (spillable) - #25075
Merged
rluvaton merged 1 commit intoSep 9, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25075 +/- ##
==========================================
- Coverage 81.74% 81.74% -0.01%
==========================================
Files 1128 1128
Lines 416644 416645 +1
Branches 416644 416645 +1
==========================================
- Hits 340592 340578 -14
- Misses 55995 56005 +10
- Partials 20057 20062 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
While adding fuzz tests for aggregate streams I encounter OOMs that partial reduce takes up all the memory and leave nothing to partial
Same as:
datafusion/datafusion/physical-plan/src/aggregates/grouped_hash_stream.rs
Lines 544 to 546 in a5c809f
What changes are included in this PR?
mark reduce hash aggregate stream as spillable
What is the testing strategy for this PR?
This was found as part of:
Are there any user-facing changes?
No