Skip to content

chore: mark partial reduce stream as can handle back pressure (spillable) #25075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rluvaton merged 1 commit into from
Sep 9, 2026
+7 −0
Merged

chore: mark partial reduce stream as can handle back pressure (spillable) #25075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions datafusion/physical-plan/src/aggregates/hash_stream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,9 @@ impl PartialHashAggregateStream {

let reservation =
MemoryConsumer::new(format!("PartialHashAggregateStream[{partition}]"))
// We interpret 'can spill' as 'can handle memory back pressure'.
// This value needs to be set to true for the default memory pool implementations
// to ensure fair application of back pressure amongst the memory consumers.
.with_can_spill(true)
.register(context.memory_pool());

Expand Down
4 changes: 4 additions & 0 deletions datafusion/physical-plan/src/aggregates/partial_reduce_stream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,10 @@ impl PartialReduceHashAggregateStream {

let reservation =
MemoryConsumer::new(format!("PartialReduceHashAggregateStream[{partition}]"))
// We interpret 'can spill' as 'can handle memory back pressure'.
// This value needs to be set to true for the default memory pool implementations
// to ensure fair application of back pressure amongst the memory consumers.
.with_can_spill(true)
.register(context.memory_pool());

Ok(Self {
Expand Down