use requirements.txt to formalize python deps

[jimexist]

Which issue does this PR close?

Closes#504.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

[codecov-commenter]

Codecov Report

Merging #484 (dfef5af) into master (e713bc3) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #484 +/- ##
=======================================
Coverage 75.95% 75.95% =======================================
Files 154 154 Lines 26349 26349 =======================================
Hits 20014 20014 Misses 6335 6335 

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e713bc3...dfef5af. Read the comment docs.

[jorgecarleitao]

Looks great. Great to see pip-tools being used :)

What do you think about adding to the README how to update test dependencies? Something like

To change test dependencies, change the requirements.in and run

# change requirements.in
pip install pip-tools
pip-compile --generate-hashes

To update dependencies, run

pip-compile update

More details here

[jimexist]

Looks great. Great to see pip-tools being used :)

What do you think about adding to the README how to update test dependencies? Something like

To change test dependencies, change the requirements.in and run

change requirements.in

pip install pip-tools

pip-compile --generate-hashes

To update dependencies, run

pip-compile update

More details here

Personally I lean towards using poetry but that demands changes to publishing procedures as well - what do you think of that?

[jorgecarleitao]

I do not quite follow: AFAIK both pip-tools and poetry are tools for Python applications, not Python libraries. For libraries, we only need to provide a setup.py / project.toml, which madurin does for us. I.e. the install_requires is here.

AFAI understand this PR is only concerned with the dependencies used for testing.

[jimexist]

I do not quite follow: AFAIK both pip-tools and poetry are tools for Python applications, not Python libraries. For libraries, we only need to provide a setup.py / project.toml, which madurin does for us. I.e. the install_requires is here.

AFAI understand this PR is only concerned with the dependencies used for testing.

i meant the format for defining the project (the poetry way), but you are right this is probably non-related to this PR.

[jimexist]

I do not quite follow: AFAIK both pip-tools and poetry are tools for Python applications, not Python libraries. For libraries, we only need to provide a setup.py / project.toml, which madurin does for us. I.e. the install_requires is here.

AFAI understand this PR is only concerned with the dependencies used for testing.

README.md updated, PTAL