Skip to content

Define the unittests using pytest - #493

Merged
alamb merged 9 commits into
apache:masterfrom
kszucs:pytest
Jun 9, 2021
Merged

Define the unittests using pytest#493
alamb merged 9 commits into
apache:masterfrom
kszucs:pytest

Conversation

@kszucs

Copy link
Copy Markdown
Member

Rationale for this change

pytest is more convenient for writing python tests and we should be able to reuse the testing suite define in pyarrow.

What changes are included in this PR?

Are there any user-facing changes?

@codecov-commenter

codecov-commenter commented Jun 3, 2021

Copy link
Copy Markdown

Codecov Report

Merging #493 (00ce946) into master (b84789a) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #493 +/- ##
==========================================
- Coverage 76.09% 76.07% -0.02% 
==========================================
Files 155 156 +1 Lines 26575 26750 +175 ==========================================
+ Hits 20221 20351 +130 - Misses 6354 6399 +45 
Impacted FilesCoverage Δ
datafusion-cli/src/lib.rs0.00% <0.00%> (ø)
datafusion-cli/src/main.rs0.00% <0.00%> (ø)
...lista/rust/core/src/serde/logical_plan/to_proto.rs61.64% <0.00%> (-0.77%)⬇️
...sta/rust/core/src/serde/logical_plan/from_proto.rs35.41% <0.00%> (-0.51%)⬇️
datafusion/src/sql/utils.rs66.54% <0.00%> (-0.25%)⬇️
datafusion/src/optimizer/utils.rs48.05% <0.00%> (-0.18%)⬇️
...ta/rust/core/src/serde/physical_plan/from_proto.rs38.51% <0.00%> (-0.14%)⬇️
datafusion/src/logical_plan/expr.rs84.56% <0.00%> (-0.05%)⬇️
datafusion/src/physical_plan/planner.rs80.19% <0.00%> (ø)
datafusion/src/physical_plan/window_frames.rs86.60% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee2b9ef...00ce946. Read the comment docs.

@jorgecarleitaojorgecarleitao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Comment threadpython/tests/test_sql.py Outdated
@jimexist

Copy link
Copy Markdown
Member

see related #484

@alamb

alamb commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

@kszucs FYI PR now needs to be rebased. I agree btw that pytest is really nice (and much nicer than unittest) 👍

@alambalamb added the python label Jun 4, 2021
@jorgecarleitao

Copy link
Copy Markdown
Member

Do we need two requirements files? I think we only need one, for the tests?

@kszucs

Copy link
Copy Markdown
MemberAuthor

We used multiple requirements file in pyarrow for easier dependency composition. Though there are nicer ways to define multiple kinds of dependency. I don't have a strong preference, so I'm going to add pytest to the requiremets.txt file.

@jorgecarleitaojorgecarleitao changed the title [Python] Define the unittests using pytestDefine the unittests using pytestJun 7, 2021
@alamb
alamb merged commit 42f908e into apache:masterJun 9, 2021
@alambalamb mentioned this pull request Jun 6, 2022
unkloud pushed a commit to unkloud/datafusion that referenced this pull request Mar 23, 2025
## Rationale for this change
To be ready for Spark 4.0
## What changes are included in this PR?
This PR enables the comet tests with the spark-4.0 profile
## How are these changes tested?
Tests with the spark-4.0 profile now should pass. (But Spark tests do not yet)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@kszucs@codecov-commenter@jimexist@alamb@jorgecarleitao