Uh oh!
There was an error while loading. Please reload this page.
Minor: Reduce more #cfg(feature = "parquet") in tests - #7934
Closed
alamb wants to merge 7 commits into
Closed
Conversation
#cfg(feature = "parquet")#cfg(feature = "parquet")#cfg(feature = "parquet")#cfg(feature = "parquet") in tets#cfg(feature = "parquet") in tets#cfg(feature = "parquet") in testsalamb
marked this pull request as ready for review
October 26, 2023 13:56
Weijun-H
left a comment
Member
There was a problem hiding this comment.
It failed when running cargo test --package datafusion-common
msirek
reviewed
Nov 6, 2023
Uh oh!
There was an error while loading. Please reload this page.
alamb
commented
Nov 8, 2023
ContributorAuthor
@andygrove I wonder if you have time to review this PR? |
alamb
commented
Nov 28, 2023
ContributorAuthor
This PR is slowly bitrotting, Given no one seems to care, I'll close this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #7745
Rationale for this change
#7745 adds a new
parquetfeature flag. However, it did by adding a lot of#[cfg]over the codebase.I believe it is important to keep the codebase as easy to work with as possible, to keep the barrier to new contributors down and encourage additional contributions. Having many
#[cfg]in various parts of the code means that even people working on things not related to parquet have to worry about those cfgs.What changes are included in this PR?
#cfgand instead isolates the parquet specific code to their own modules, with stub implementations when the feature is not enabled.Are these changes tested?
Existing tests
Are there any user-facing changes?
No