Uh oh!
There was an error while loading. Please reload this page.
Minor: extend ci to test each package - #7940
Conversation
alamb
commented
Oct 26, 2023
FYI CI is going to fail #7939 |
| - name: Check workspace without default features | ||
| run: cargo check --no-default-features -p datafusion | ||
| - name: Check workspace without default features in each package tests |
There was a problem hiding this comment.
This is a really neat way of iterating over the packages
Weijun-H
commented
Oct 26, 2023
Draft until fix #7933 |
alamb
commented
Oct 26, 2023
BTW there are a few other outstanding PRs that might help get the checks working -- #7934 |
alamb
commented
Oct 26, 2023
#7933 is fixed |
3149b3f to
4ec8399Compare| - name: Check tests in each package | ||
| run: | | ||
| for package in $(cargo metadata --no-deps --format-version 1 | jq -r '.packages[].name'); do | ||
| cargo check --tests --package "$package" || exit 1 | ||
| done |
There was a problem hiding this comment.
I am not sure if we need --no-default-features to check tests 🤔
There was a problem hiding this comment.
I think this command verifies that cargo test --package "$package" will compile successfully, but it doesn't check if cargo test --no-default-features --package "$package" would run successfully
But I am not sure how common running cargo test --no-default-features --package "$package" is 🤔
alamb
commented
Oct 29, 2023
This PR looks like it would be good to go if it got rebased against main -- is that correct @Weijun-H ? |
Weijun-H
commented
Oct 29, 2023
Yes, it is. |
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
Which issue does this PR close?
Related #7933
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?