Uh oh!
There was an error while loading. Please reload this page.
feat: support stride in array_slice, change indexes to be1 based - #8829
Merged
Conversation
stride in array_sliceUh oh!
There was an error while loading. Please reload this page.
| query error Execution error: array_slice got invalid stride: 0, it cannot be 0 | ||
| select array_slice(make_array(1, 2, 3, 4, 5), 1, 5, 0), array_slice(make_array('h', 'e', 'l', 'l', 'o'), 1, 5, 0); | ||
Contributor
There was a problem hiding this comment.
SELECT([1, 2, 3, 4, 5])[4:2:-2]; are also needed. And other examples in duckdb, we should consider them too.
MemberAuthor
There was a problem hiding this comment.
Yes, I think so. And we could do it in ticket #8830 .
Weijun-H
marked this pull request as draft
January 11, 2024 13:52
Weijun-Hforce-pushed
the
feat-array-slice-stride
branch
from
January 12, 2024 06:07
6b56383 to
d41c3a2CompareWeijun-H
marked this pull request as ready for review
January 12, 2024 06:07
| let end = offset_window[1]; | ||
| let len = end - start; | ||
| let stride = if let Some(stride) = stride { |
Contributor
There was a problem hiding this comment.
this construction most likely can be replaced by .map/.and_then ?
| (start + to + O::usize_as(1)).to_usize().unwrap(), | ||
| ); | ||
| offsets.push(offsets[row_index] + (to - from + O::usize_as(1))); | ||
| if let Some(stride) = stride { |
| ArraySlice, | ||
| array_slice, | ||
| array offset length, | ||
| array offset length stride, |
Contributor
There was a problem hiding this comment.
It seems offset length is incorrect, it should be begin end
stride in array_slicestride in array_sliceWeijun-Hforce-pushed
the
feat-array-slice-stride
branch
from
January 13, 2024 06:02
d11a0cc to
977f2e1CompareWeijun-H
commented
Jan 13, 2024
MemberAuthor
stalled until #8847 fixed |
| }; | ||
| if let (Some(from), Some(to)) = (from_index, to_index) { | ||
| let stride = stride.map(|s| s.value(row_index)); |
alamb
marked this pull request as draft
January 15, 2024 10:49
alamb
commented
Jan 15, 2024
Contributor
Marking as draft to make it clear this PR is not waiting on review |
Weijun-Hforce-pushed
the
feat-array-slice-stride
branch
from
January 15, 2024 11:52
977f2e1 to
297ef22CompareWeijun-H
marked this pull request as ready for review
January 15, 2024 13:17
9 tasks
stride in array_slicestride in array_slice, change indexes to be 1 basedstride in array_slice, change indexes to be 1 basedstride in array_slice, change indexes to be0 basedWeijun-H
commented
Jan 20, 2024
MemberAuthor
stride in array_slice, change indexes to be0 basedstride in array_slice, change indexes to be1 basedalamb
commented
Jan 21, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes#8784
Rationale for this change
What changes are included in this PR?
support array_slice with stride argument
Are these changes tested?
Are there any user-facing changes?