Uh oh!
There was an error while loading. Please reload this page.
Minor: fix wrong function call - #8847
Conversation
alamb
left a comment
There was a problem hiding this comment.
This seems like it is an oversight in our CI -- is it possible to write a test that would fail without this code change 🤔
Nice catch
Weijun-H
commented
Jan 13, 2024
The problem may not related to ci, because I tested it on cli, and it also worked. @alamb |
alamb
commented
Jan 14, 2024
Right, sorry, what I was saying is that given there is a bug you found in the code (by manual inspection) but
I conclude there is a gap in our test coverage. Thus I was suggesting we find a way to write a test that would fail prior to this code change, but will pass with the change |
Weijun-H
commented
Jan 15, 2024
alamb
commented
Jan 15, 2024
Thanks again @Weijun-H |
Which issue does this PR close?
Closes #.
Rationale for this change
This issue is called #8744 , but I am curious why it passed the ci 🤔
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?