Skip to content

[fix](nereids) Mistaken stats when analyzing table incrementally and partition number less than 512 - #23507

Merged
englefly merged 1 commit into
apache:masterfrom
Kikyou1997:fix/mistaken_stats_for_incremental_analyze_when_analyzed_partition_less_than_512
Aug 28, 2023
Merged

[fix](nereids) Mistaken stats when analyzing table incrementally and partition number less than 512#23507
englefly merged 1 commit into
apache:masterfrom
Kikyou1997:fix/mistaken_stats_for_incremental_analyze_when_analyzed_partition_less_than_512

Conversation

@Kikyou1997

@Kikyou1997Kikyou1997 commented Aug 25, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

  1. Fix bug that mistaken stats when analyzing table incrementally and partition number less than 512
  2. Fix bug that cron expression lost during analyzing
  3. Mark system job as running after registered to AnalysisManager to avoid submit same jobs if previous one take long time

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Kikyou1997

Kikyou1997 commented Aug 25, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@Kikyou1997Kikyou1997 changed the title [fix][fix](nereids) Mistaken stats when analyzing table incrementally and partition number less than 512Aug 25, 2023
@hello-stephen

hello-stephen commented Aug 25, 2023

Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.39 seconds
stream load tsv: 549 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162318930 Bytes

@Kikyou1997
Kikyou1997force-pushed the fix/mistaken_stats_for_incremental_analyze_when_analyzed_partition_less_than_512 branch from e9add13 to a8c4fc2CompareAugust 27, 2023 03:53
@Kikyou1997

Kikyou1997 commented Aug 27, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@Kikyou1997
Kikyou1997force-pushed the fix/mistaken_stats_for_incremental_analyze_when_analyzed_partition_less_than_512 branch from a8c4fc2 to 4154182CompareAugust 27, 2023 04:01
@Kikyou1997

Kikyou1997 commented Aug 27, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

hello-stephen commented Aug 27, 2023

Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.69 seconds
stream load tsv: 534 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162049509 Bytes

@Kikyou1997
Kikyou1997force-pushed the fix/mistaken_stats_for_incremental_analyze_when_analyzed_partition_less_than_512 branch from 4154182 to 4d55874CompareAugust 27, 2023 04:41
@Kikyou1997

Kikyou1997 commented Aug 27, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

hello-stephen commented Aug 27, 2023

Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.71 seconds
stream load tsv: 535 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162147681 Bytes

@hello-stephen

hello-stephen commented Aug 27, 2023

Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.66 seconds
stream load tsv: 533 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162234447 Bytes

morrySnow
morrySnow reviewed Aug 28, 2023
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/statistics/OlapAnalysisTask.java Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/statistics/OlapAnalysisTask.java Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/statistics/OlapAnalysisTask.java Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/statistics/BaseAnalysisTask.java Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java
Comment threadfe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsAutoAnalyzer.java
if (!StatisticsUtil.statsTblAvailable()) {
return;
}
analyzePeriodically();

@morrySnowmorrySnowAug 28, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perroid analyze should in a serperate thread

@Kikyou1997Kikyou1997Aug 28, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quite agree with this, but this is a bug-fix pr other than refacor

@Kikyou1997
Kikyou1997force-pushed the fix/mistaken_stats_for_incremental_analyze_when_analyzed_partition_less_than_512 branch from 4d55874 to 123aa9aCompareAugust 28, 2023 02:58
@Kikyou1997

Kikyou1997 commented Aug 28, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

hello-stephen commented Aug 28, 2023

Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.93 seconds
stream load tsv: 534 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17161912727 Bytes

@github-actions

github-actionsBot commented Aug 28, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 28, 2023
@github-actions

github-actionsBot commented Aug 28, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@englefly
englefly merged commit 10792ca into apache:masterAug 28, 2023
@Kikyou1997Kikyou1997 mentioned this pull request Oct 12, 2023
Merged
morningman pushed a commit that referenced this pull request Oct 13, 2023
@Kikyou1997
[refactor][backport](stats) Migrate stats framework from master to br…
4b6ff32
…anch 2.0 (#25119)
This PR is composed of belowing commits which has been merged to Doirs master:
* #24769
* #24672
* #24599
* #24521
* #24405
* #24237
* #24135
* #24074
* #24026
* #23992
* #23978
* #23622
* #23507
* #23354
* #23103
* #22963
* #22896
* #22775
* #22773
morningman pushed a commit that referenced this pull request Oct 15, 2023
@Kikyou1997
[branch2.0](backport) Migrate stats framework from master to branch-2…
3daa4cd
….0 (#25421)
This PR is composed of belowing commits which has been merged to Doirs master:
* #24769
* #24672
* #24599
* #24521
* #24405
* #24237
* #24135
* #24074
* #24026
* #23992
* #23978
* #23622
* #23507
* #23354
* #23103
* #22963
* #22896
* #22775
* #22773
After this PR, when user upgrade Doris from 2.0.2 to 2.0.3, the origin info in AnalysisManager will be ignored, and the new module AnalysisManagerV2 will be saved(with more info).
@morningmanmorningman mentioned this pull request Oct 15, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@engleflyengleflyenglefly approved these changes
@morrySnowmorrySnowmorrySnow approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kikyou1997@hello-stephen@englefly@morrySnow