Skip to content

[enhancement](stats) audit for stats collection - #24074

Merged
yiguolei merged 1 commit into
apache:masterfrom
Kikyou1997:feat/audit_log
Sep 11, 2023
Merged

[enhancement](stats) audit for stats collection#24074
yiguolei merged 1 commit into
apache:masterfrom
Kikyou1997:feat/audit_log

Conversation

@Kikyou1997

@Kikyou1997Kikyou1997 commented Sep 8, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

log stas collection sqls in audit log

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Kikyou1997

Kikyou1997 commented Sep 8, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Sep 8, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.35 seconds
stream load tsv: 532 seconds loaded 74807831229 Bytes, about 134 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162175719 Bytes

wm1581066
wm1581066 approved these changes Sep 9, 2023
View reviewed changes

@wm1581066wm1581066 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Sep 9, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morrySnowmorrySnow changed the title [enhancement](optimizer) audit for stats collection[enhancement](stats) audit for stats collectionSep 9, 2023
@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 9, 2023
@github-actions

github-actionsBot commented Sep 9, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@yiguolei
yiguolei merged commit 31bffdb into apache:masterSep 11, 2023
@Kikyou1997Kikyou1997 mentioned this pull request Oct 12, 2023
Merged
morningman pushed a commit that referenced this pull request Oct 13, 2023
@Kikyou1997
[refactor][backport](stats) Migrate stats framework from master to br…
4b6ff32
…anch 2.0 (#25119)
This PR is composed of belowing commits which has been merged to Doirs master:
* #24769
* #24672
* #24599
* #24521
* #24405
* #24237
* #24135
* #24074
* #24026
* #23992
* #23978
* #23622
* #23507
* #23354
* #23103
* #22963
* #22896
* #22775
* #22773
morningman pushed a commit that referenced this pull request Oct 15, 2023
@Kikyou1997
[branch2.0](backport) Migrate stats framework from master to branch-2…
3daa4cd
….0 (#25421)
This PR is composed of belowing commits which has been merged to Doirs master:
* #24769
* #24672
* #24599
* #24521
* #24405
* #24237
* #24135
* #24074
* #24026
* #23992
* #23978
* #23622
* #23507
* #23354
* #23103
* #22963
* #22896
* #22775
* #22773
After this PR, when user upgrade Doris from 2.0.2 to 2.0.3, the origin info in AnalysisManager will be ignored, and the new module AnalysisManagerV2 will be saved(with more info).
@morningmanmorningman mentioned this pull request Oct 15, 2023
Merged
RoanHeNaN
RoanHeNaN reviewed Dec 13, 2023
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/qe/AuditLogHelper.java
MetricRepo.HISTO_QUERY_LATENCY.update(elapseMs);
MetricRepo.USER_HISTO_QUERY_LATENCY.getOrAdd(ctx.getQualifiedUser()).update(elapseMs);

if (elapseMs > Config.qe_slow_log_ms) {

@RoanHeNaNRoanHeNaNDec 13, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why just record sqlDigest of Slowquery?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnowmorrySnowmorrySnow approved these changes
+2 more reviewers
@RoanHeNaNRoanHeNaNRoanHeNaN left review comments
@wm1581066wm1581066wm1581066 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.3-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Kikyou1997@doris-robot@RoanHeNaN@wm1581066@morrySnow@xiaokang@yiguolei