Skip to content

[enhancement](schema) Add schema consistency check when add partition - #24707

Merged
dataroaring merged 4 commits into
apache:masterfrom
luwei16:luwei/schema-consistency-check
Sep 21, 2023
Merged

[enhancement](schema) Add schema consistency check when add partition#24707
dataroaring merged 4 commits into
apache:masterfrom
luwei16:luwei/schema-consistency-check

Conversation

@luwei16

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

When adding partition, add schema consistency check to reduce the possibility of inconsistency between FE and BE schema.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@dataroaring

Copy link
Copy Markdown
Contributor

run buildall

@luwei16

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.64 seconds
stream load tsv: 595 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162184138 Bytes

@xiaokangxiaokang added usercase Important user case type label dev/2.0.2 labels Sep 21, 2023

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be covered by case?

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 21, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@luwei16

Copy link
Copy Markdown
ContributorAuthor

Can it be covered by case?

Existing regression cases can partially cover it, but the code with meta_changed = true cannot be covered because this is an abnormal scenario.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.2-mergedreviewedusercaseImportant user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@luwei16@dataroaring@doris-robot@morningman@ByteYue@Yukang-Lian@xiaokang