Skip to content

[fix](schema) Table column order is changed if add a column and do truncate - #24981

Merged
yiguolei merged 1 commit into
apache:masterfrom
mymeiyi:fix-group-commit
Sep 27, 2023
Merged

[fix](schema) Table column order is changed if add a column and do truncate#24981
yiguolei merged 1 commit into
apache:masterfrom
mymeiyi:fix-group-commit

Conversation

@mymeiyi

@mymeiyimymeiyi commented Sep 27, 2023

Copy link
Copy Markdown
Contributor

#24707 introduces this bug.

The table column order is changed if add a column in the middle of all columns and then truncate, since the new added column has the max column_unique_id.

This bug lead to insert_group_commit_into_duplicate fail.

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@mymeiyi

Copy link
Copy Markdown
ContributorAuthor

run buildall

@yiguoleiyiguolei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 27, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@doris-robot

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.26 seconds
stream load tsv: 556 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size: 17162278919 Bytes

@yujun777yujun777 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhannngchenzhannngchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
yiguolei merged commit 391a4e2 into apache:masterSep 27, 2023
@xiaokangxiaokang mentioned this pull request Sep 28, 2023
vinlee19 pushed a commit to vinlee19/doris that referenced this pull request Oct 7, 2023
morningman pushed a commit to morningman/doris that referenced this pull request Oct 23, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.2-mergedp0_bp0_cp0_wreviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@mymeiyi@doris-robot@yujun777@yiguolei@zhannngchen@xiaokang