[enhancement](merge-on-write) refine tablet meta_lock usage and add some trace log by zhannngchen · Pull Request #25124 · apache/doris

zhannngchen · 2023-10-08T08:57:28Z

Proposed changes

Issue Number: close #xxx

change to read lock while save_meta(), in the method _delete_stale_rowset_by_version.
make TRACE_TABLET_LOCK_THRESHOLD shorter
print detailed trace if update_delete_bitmap takes too long time
return on _load_rowset_segments() error status
print detailed trace if save_meta too slow

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

zhannngchen · 2023-10-08T08:57:42Z

run buildall

github-actions · 2023-10-08T09:05:07Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2023-10-08T09:19:57Z

TeamCity be ut coverage result:
Function Coverage: 36.29% (8149/22458)
Line Coverage: 28.42% (65175/229337)
Region Coverage: 27.34% (33769/123501)
Branch Coverage: 24.02% (17210/71648)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d7778b080e56808f721efb4795e1ca8bd0c098be_d7778b080e56808f721efb4795e1ca8bd0c098be/report/index.html

doris-robot · 2023-10-08T09:27:32Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.83 seconds
stream load tsv: 574 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162525884 Bytes

zhannngchen · 2023-10-08T11:44:24Z

run buildall

github-actions · 2023-10-08T11:52:18Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2023-10-08T12:03:37Z

TeamCity be ut coverage result:
Function Coverage: 36.28% (8147/22454)
Line Coverage: 28.41% (65166/229340)
Region Coverage: 27.33% (33754/123494)
Branch Coverage: 24.02% (17210/71644)
Coverage Report: http://coverage.selectdb-in.cc/coverage/916a2d1c2fc0abf717ebc3478e9c1f27456937d7_916a2d1c2fc0abf717ebc3478e9c1f27456937d7/report/index.html

doris-robot · 2023-10-08T12:22:34Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.82 seconds
stream load tsv: 579 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162422991 Bytes

github-actions · 2023-10-09T10:25:56Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2023-10-10T03:09:16Z

clang-tidy review says "All clean, LGTM! 👍"

zhannngchen · 2023-10-10T12:19:51Z

run buildall

github-actions · 2023-10-10T12:26:54Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2023-10-10T12:37:33Z

TeamCity be ut coverage result:
Function Coverage: 36.28% (8149/22459)
Line Coverage: 28.43% (65191/229298)
Region Coverage: 27.36% (33777/123473)
Branch Coverage: 24.03% (17210/71616)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3e51d154dc763369fb1be63f42870369c9018caf_3e51d154dc763369fb1be63f42870369c9018caf/report/index.html

doris-robot · 2023-10-10T12:52:08Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.87 seconds
stream load tsv: 552 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17161964924 Bytes

zhannngchen · 2023-10-10T14:06:50Z

run buildall

github-actions · 2023-10-10T14:14:33Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2023-10-10T14:24:19Z

TeamCity be ut coverage result:
Function Coverage: 36.31% (8149/22445)
Line Coverage: 28.44% (65195/229262)
Region Coverage: 27.36% (33780/123449)
Branch Coverage: 24.04% (17212/71608)
Coverage Report: http://coverage.selectdb-in.cc/coverage/771def7da86cf64964078fb0912ac88a143194a8_771def7da86cf64964078fb0912ac88a143194a8/report/index.html

doris-robot · 2023-10-10T14:42:42Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.18 seconds
stream load tsv: 563 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162191719 Bytes

zhannngchen · 2023-10-12T07:38:04Z

run p0

github-actions · 2023-10-12T09:30:20Z

PR approved by at least one committer and no changes requested.

github-actions · 2023-10-12T09:30:24Z

PR approved by anyone and no changes requested.

liaoxin01

LGTM

fix format error introduced by #25124 The clang format check had a bug before, so PR 25124 can pass the check at that time.

…ome trace log (#25124)

fix format error introduced by #25124 The clang format check had a bug before, so PR 25124 can pass the check at that time.

…ome trace log (apache#25124)

fix format error introduced by apache#25124 The clang format check had a bug before, so PR 25124 can pass the check at that time.

zhannngchen added 2 commits October 8, 2023 12:54

[enhancement](merge-on-write) add detailed trace while publish
18a3297

update
d7778b0

reformat code
916a2d1

zhannngchen added the dev/2.0.3 label Oct 9, 2023

refine lock
30b1f53

update log
74e29d3

zhannngchen changed the title ~~[enhancement](merge-on-write) refine trace log~~[enhancement](merge-on-write) refine tablet meta_lock usage and add some trace logOct 10, 2023

update
3e51d15

update
771def7

dataroaring approved these changes Oct 12, 2023
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 12, 2023

github-actionsBot added the reviewed label Oct 12, 2023

liaoxin01 approved these changes Oct 13, 2023
View reviewed changes

zhannngchen merged commit fc40788 into apache:masterOct 13, 2023

hello-stephen mentioned this pull request Oct 13, 2023
[chore](format) fix tablet_meta.cpp #25410
Merged

zhangstar333 pushed a commit that referenced this pull request Oct 13, 2023
[chore](format) fix tablet_meta.cpp (#25410)
9f67bcf
fix format error introduced by #25124 The clang format check had a bug before, so PR 25124 can pass the check at that time.

xiaokang added merge_conflict dev/2.0.3-merged and removed dev/2.0.3 labels Oct 13, 2023

xiaokang pushed a commit that referenced this pull request Oct 13, 2023
[enhancement](merge-on-write) refine tablet meta_lock usage and add s…
3bc4fed
…ome trace log (#25124)

xiaokang pushed a commit that referenced this pull request Oct 16, 2023
[chore](format) fix tablet_meta.cpp (#25410)
01bca9d
fix format error introduced by #25124 The clang format check had a bug before, so PR 25124 can pass the check at that time.

dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
[enhancement](merge-on-write) refine tablet meta_lock usage and add s…
107b9fe
…ome trace log (apache#25124)

dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
[chore](format) fix tablet_meta.cpp (apache#25410)
0f6092e
fix format error introduced by apache#25124 The clang format check had a bug before, so PR 25124 can pass the check at that time.

XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
[chore](format) fix tablet_meta.cpp (apache#25410)
8e96f66
fix format error introduced by apache#25124 The clang format check had a bug before, so PR 25124 can pass the check at that time.

Uh oh!

Conversation

zhannngchen commented Oct 8, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Further comments

Uh oh!

zhannngchen commented Oct 8, 2023

Uh oh!

github-actionsBot commented Oct 8, 2023

Uh oh!

doris-robot commented Oct 8, 2023

Uh oh!

doris-robot commented Oct 8, 2023

Uh oh!

zhannngchen commented Oct 8, 2023

Uh oh!

github-actionsBot commented Oct 8, 2023

Uh oh!

doris-robot commented Oct 8, 2023

Uh oh!

doris-robot commented Oct 8, 2023

Uh oh!

github-actionsBot commented Oct 9, 2023

Uh oh!

github-actionsBot commented Oct 10, 2023

Uh oh!

zhannngchen commented Oct 10, 2023

Uh oh!

github-actionsBot commented Oct 10, 2023

Uh oh!

doris-robot commented Oct 10, 2023

Uh oh!

doris-robot commented Oct 10, 2023

Uh oh!

zhannngchen commented Oct 10, 2023

Uh oh!

github-actionsBot commented Oct 10, 2023

Uh oh!

doris-robot commented Oct 10, 2023

Uh oh!

doris-robot commented Oct 10, 2023

Uh oh!

zhannngchen commented Oct 12, 2023

Uh oh!

github-actionsBot commented Oct 12, 2023

Uh oh!

github-actionsBot commented Oct 12, 2023

Uh oh!

liaoxin01 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zhannngchen commented Oct 8, 2023•
edited
Loading