Skip to content

[chore](format) fix tablet_meta.cpp - #25410

Merged
zhangstar333 merged 1 commit into
apache:masterfrom
hello-stephen:patch-18
Oct 13, 2023
Merged

[chore](format) fix tablet_meta.cpp#25410
zhangstar333 merged 1 commit into
apache:masterfrom
hello-stephen:patch-18

Conversation

@hello-stephen

@hello-stephenhello-stephen commented Oct 13, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

fix format error introduced by #25124

The clang format check had a bug before, so PR 25124 can pass the check at that time.

@hello-stephen

hello-stephen commented Oct 13, 2023

Copy link
Copy Markdown
ContributorAuthor

run buildall

zy-kkk
zy-kkk approved these changes Oct 13, 2023
View reviewed changes

@zy-kkkzy-kkk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Oct 13, 2023
@github-actions

github-actionsBot commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

amorynan
amorynan approved these changes Oct 13, 2023
View reviewed changes

@amorynanamorynan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot

doris-robot commented Oct 13, 2023

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.30% (8144/22436)
Line Coverage: 28.51% (65283/228997)
Region Coverage: 27.20% (33810/124318)
Branch Coverage: 24.00% (17255/71900)
Coverage Report: http://coverage.selectdb-in.cc/coverage/27637d52feb03f107b6d67387d21f65f4f095ea4_27637d52feb03f107b6d67387d21f65f4f095ea4/report/index.html

@doris-robot

doris-robot commented Oct 13, 2023

Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.25 seconds
stream load tsv: 573 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162512817 Bytes

@zhangstar333
zhangstar333 merged commit 9f67bcf into apache:masterOct 13, 2023
@hello-stephen
hello-stephen deleted the patch-18 branch October 13, 2023 09:59
xiaokang pushed a commit that referenced this pull request Oct 16, 2023
@hello-stephen@xiaokang
[chore](format) fix tablet_meta.cpp (#25410)
01bca9d
fix format error introduced by #25124
The clang format check had a bug before, so PR 25124 can pass the check at that time.
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@hello-stephen王翔宇
[chore](format) fix tablet_meta.cpp (apache#25410)
0f6092e
fix format error introduced by apache#25124
The clang format check had a bug before, so PR 25124 can pass the check at that time.
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@hello-stephen胥剑旭
[chore](format) fix tablet_meta.cpp (apache#25410)
8e96f66
fix format error introduced by apache#25124
The clang format check had a bug before, so PR 25124 can pass the check at that time.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zy-kkkzy-kkkzy-kkk approved these changes
@zhangstar333zhangstar333zhangstar333 approved these changes
+1 more reviewer
@amorynanamorynanamorynan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.3-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hello-stephen@doris-robot@amorynan@zy-kkk@zhangstar333@xiaokang