Uh oh!
There was an error while loading. Please reload this page.
[fix](outfile) Fix unable to export empty data - #30703
Conversation
doris-robot
commented
Feb 1, 2024
Thank you for your contribution to Apache Doris. |
clang-tidy review says "All clean, LGTM! 👍" |
hello-stephen
commented
Feb 1, 2024
run performance |
doris-robot
commented
Feb 1, 2024
TPC-H: Total hot run time: 37078 ms |
doris-robot
commented
Feb 1, 2024
TPC-DS: Total hot run time: 174837 ms |
doris-robot
commented
Feb 1, 2024
ClickBench: Total hot run time: 31.41 s |
doris-robot
commented
Feb 1, 2024
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
19545d0 to
5e0e28fCompareclang-tidy review says "All clean, LGTM! 👍" |
zxealous
commented
Feb 4, 2024
run buildall |
doris-robot
commented
Feb 4, 2024
TPC-H: Total hot run time: 37046 ms |
doris-robot
commented
Feb 4, 2024
TeamCity be ut coverage result: |
doris-robot
commented
Feb 4, 2024
TPC-DS: Total hot run time: 181119 ms |
doris-robot
commented
Feb 4, 2024
ClickBench: Total hot run time: 31.03 s |
doris-robot
commented
Feb 4, 2024
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
morningman
left a comment
There was a problem hiding this comment.
LGTM, please add regression test case
| DCHECK(buf != nullptr); | ||
| buf->set_upload_to_remote([this](UploadFileBuffer& b) { _put_object(b); }); | ||
| } else { | ||
| // if there is no pending buffer, we need to create a empty file |
There was a problem hiding this comment.
| // if there is no pending buffer, we need to create a empty file | |
| // if there is no pending buffer, we need to create an empty file |
clang-tidy review says "All clean, LGTM! 👍" |
zxealous
commented
Feb 18, 2024
run buildall |
doris-robot
commented
Feb 18, 2024
TeamCity be ut coverage result: |
clang-tidy review says "All clean, LGTM! 👍" |
918fc88 to
bc04c05Comparezxealous
commented
Feb 18, 2024
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
doris-robot
commented
Feb 18, 2024
TeamCity be ut coverage result: |
clang-tidy review says "All clean, LGTM! 👍" |
doris-robot
commented
Feb 18, 2024
TeamCity be ut coverage result: |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
This reverts commit 99c3b5f.
kaijchen
commented
Feb 20, 2024
Hi @ zxealous, thank you for contributing to Apache Doris. Unfortunately, this PR caused a problem in the cloud pipeline, see #31148. |
Issue Number: closeapache#30600 Fix unable to export empty data to hdfs / S3, this behavior is inconsistent with version 1.2.7, version 1.2.7 can export empty data to hdfs/ S3, and there will be exported files on S3/HDFS.
Issue Number: closeapache#30600 Fix unable to export empty data to hdfs / S3, this behavior is inconsistent with version 1.2.7, version 1.2.7 can export empty data to hdfs/ S3, and there will be exported files on S3/HDFS.
…#28983#30703#31169 (#31213) * (feature)(cloud) Use dynamic allocator instead of static buffer pool for better elasticity. (#28983) * [fix](outfile) Fix unable to export empty data (#30703) Issue Number: close#30600 Fix unable to export empty data to hdfs / S3, this behavior is inconsistent with version 1.2.7, version 1.2.7 can export empty data to hdfs/ S3, and there will be exported files on S3/HDFS. * [fix](file-writer) avoid empty file for segment writer (#31169) --------- Co-authored-by: AlexYue <yj976240184@gmail.com> Co-authored-by: zxealous <zhouchangyue@baidu.com>
Issue Number: closeapache#30600 Fix unable to export empty data to hdfs / S3, this behavior is inconsistent with version 1.2.7, version 1.2.7 can export empty data to hdfs/ S3, and there will be exported files on S3/HDFS.
Proposed changes
Issue Number: close#30600
Fix unable to export empty data to hdfs / S3, this behavior is inconsistent with version 1.2.7, version 1.2.7 can export empty data to hdfs/ S3, and there will be exported files on S3/HDFS.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...