Skip to content

[fix](file-writer) avoid empty file for segment writer - #31169

Merged
dataroaring merged 1 commit into
apache:masterfrom
morningman:empty_file_writer
Feb 21, 2024
Merged

[fix](file-writer) avoid empty file for segment writer#31169
dataroaring merged 1 commit into
apache:masterfrom
morningman:empty_file_writer

Conversation

@morningman

@morningmanmorningman commented Feb 20, 2024

Copy link
Copy Markdown
Contributor

Proposed changes

This #30703 allow writing empty file.
But internal segment file do not allow empty file.
So I add a new FileWriterOption create_empty_file to indicate whether to
create empty file.

This only effect s3/hdfs/broker file writer

After this,

  1. For segment file, no empty file will be created.
  2. For export operation, if there is no data, empty file will be created.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot

doris-robot commented Feb 20, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@github-actions

github-actionsBot commented Feb 20, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

2 similar comments
@github-actions

github-actionsBot commented Feb 20, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

github-actionsBot commented Feb 20, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

kaijchen
kaijchen approved these changes Feb 20, 2024
View reviewed changes

@kaijchenkaijchen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Feb 20, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@kaijchenkaijchen mentioned this pull request Feb 20, 2024
Closed
@gavinchou

gavinchou commented Feb 20, 2024

Copy link
Copy Markdown
Contributor

run buildall

@doris-robot

doris-robot commented Feb 20, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 35.77% (8558/23927)
Line Coverage: 27.72% (69425/250430)
Region Coverage: 26.83% (36022/134243)
Branch Coverage: 23.65% (18430/77922)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a434614071fdf7fa9ecbacea2a8269b7d5d61c26_a434614071fdf7fa9ecbacea2a8269b7d5d61c26/report/index.html

dataroaring
dataroaring approved these changes Feb 20, 2024
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Feb 20, 2024
@github-actions

github-actionsBot commented Feb 20, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@dataroaring
dataroaring merged commit be06ef4 into apache:masterFeb 21, 2024
morningman added a commit to morningman/doris that referenced this pull request Feb 21, 2024
@morningman
[fix](file-writer) avoid empty file for segment writer (apache#31169)
888e335
morningman added a commit to morningman/doris that referenced this pull request Feb 21, 2024
@morningman
[fix](file-writer) avoid empty file for segment writer (apache#31169)
9e21783
@morningmanmorningman mentioned this pull request Feb 21, 2024
Merged
yiguolei pushed a commit that referenced this pull request Feb 21, 2024
@morningman@ByteYue@zxealous
[fix](file-writer) opt s3 file writer and fix empty file related issue…
a8d8c6a
…#28983#30703#31169 (#31213)
* (feature)(cloud) Use dynamic allocator instead of static buffer pool for better elasticity. (#28983)
* [fix](outfile) Fix unable to export empty data (#30703)
Issue Number: close#30600
Fix unable to export empty data to hdfs / S3, this behavior is inconsistent with version 1.2.7,
version 1.2.7 can export empty data to hdfs/ S3, and there will be exported files on S3/HDFS.
* [fix](file-writer) avoid empty file for segment writer (#31169)
---------
Co-authored-by: AlexYue <yj976240184@gmail.com>
Co-authored-by: zxealous <zhouchangyue@baidu.com>
@morningmanmorningman mentioned this pull request Feb 23, 2024
Merged
morningman added a commit that referenced this pull request Feb 25, 2024
@morningman
[fix](file-writer) avoid empty file for segment writer (#31355)
65a939c
bp #31169
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@morningmanweixingyu12
[fix](file-writer) avoid empty file for segment writer (apache#31355)
eeac979
bp apache#31169
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@morningman@HappenLee
[fix](file-writer) avoid empty file for segment writer (apache#31169)
ed34fd9
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaringdataroaringdataroaring approved these changes
+1 more reviewer
@kaijchenkaijchenkaijchen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.6-mergeddev/2.1.0-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@morningman@doris-robot@gavinchou@kaijchen@dataroaring@yiguolei