[Fix](nereids) modify the binding aggregate function in order by by feiniaofeiafei · Pull Request #32758 · apache/doris

feiniaofeiafei · 2024-03-25T07:08:53Z

modify the bind logical to make the order by has same behavior with mysql when sort child is aggregate.
when an order by Expr has aggregate function, all slots in this order by Expr should bind the LogicalAggregate non-AggFunction outputs first, then bind the LogicalAggregate Child
e.g.
select 2*abs(sum(c1)) as c1, c1,sum(c1)+c1 from t_order_by_bind_priority group by c1 order by sum(c1)+c1 asc;
in this sql, the two c1 in order by all bind to the c1 in t_order_by_bind_priority

doris-robot · 2024-03-25T07:08:58Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

feiniaofeiafei · 2024-03-25T07:09:32Z

run buildall

doris-robot · 2024-03-25T07:33:58Z

TPC-H: Total hot run time: 38644 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ad1061fb17860316e118109a590b7bed084e877c, data reload: false
------ Round 1 ----------------------------------
q1	17878	4523	4276	4276
q2	2643	165	163	163
q3	11969	1174	1241	1174
q4	10692	820	756	756
q5	7627	3127	3029	3029
q6	209	124	126	124
q7	1072	626	593	593
q8	9399	2064	2054	2054
q9	7447	6769	6725	6725
q10	8490	3485	3575	3485
q11	429	231	222	222
q12	378	201	198	198
q13	17919	2909	2873	2873
q14	246	202	220	202
q15	514	456	455	455
q16	496	377	370	370
q17	973	582	598	582
q18	7210	6642	6462	6462
q19	3564	1512	1405	1405
q20	564	257	250	250
q21	3568	3002	2946	2946
q22	350	308	300	300
Total cold run time: 113637 ms
Total hot run time: 38644 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4112	4140	4140	4140
q2	323	225	230	225
q3	3038	2860	2845	2845
q4	1872	1556	1635	1556
q5	5332	5354	5388	5354
q6	194	116	117	116
q7	2239	1894	1875	1875
q8	3173	3296	3290	3290
q9	8822	8685	8751	8685
q10	3817	3775	3850	3775
q11	553	447	443	443
q12	723	536	553	536
q13	16892	2870	2867	2867
q14	283	265	251	251
q15	503	446	460	446
q16	474	424	413	413
q17	1733	1515	1467	1467
q18	7491	7210	7106	7106
q19	1671	1561	1493	1493
q20	1900	1766	1708	1708
q21	4815	4854	4661	4661
q22	518	420	450	420
Total cold run time: 70478 ms
Total hot run time: 53672 ms

doris-robot · 2024-03-25T07:46:11Z

TPC-DS: Total hot run time: 187092 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ad1061fb17860316e118109a590b7bed084e877c, data reload: false
query1	934	362	357	357
query2	7382	1930	1889	1889
query3	6715	211	214	211
query4	31616	21390	21403	21390
query5	4426	401	420	401
query6	268	174	181	174
query7	4627	294	295	294
query8	230	173	177	173
query9	9321	2293	2272	2272
query10	561	237	258	237
query11	14826	14398	14406	14398
query12	130	87	85	85
query13	1638	408	415	408
query14	14194	11331	11402	11331
query15	270	203	192	192
query16	8236	254	254	254
query17	2012	576	559	559
query18	2101	288	282	282
query19	352	154	155	154
query20	94	87	89	87
query21	199	130	127	127
query22	5029	4857	4810	4810
query23	33500	32872	32712	32712
query24	12223	2878	2911	2878
query25	622	381	388	381
query26	1734	154	155	154
query27	2812	350	357	350
query28	7211	1872	1861	1861
query29	1017	665	625	625
query30	305	151	152	151
query31	974	730	737	730
query32	87	61	58	58
query33	765	257	248	248
query34	996	479	499	479
query35	834	634	607	607
query36	1031	889	877	877
query37	253	78	82	78
query38	3555	3447	3421	3421
query39	1475	1460	1414	1414
query40	293	116	113	113
query41	51	47	47	47
query42	109	97	97	97
query43	479	455	443	443
query44	1151	733	713	713
query45	257	269	268	268
query46	1116	720	691	691
query47	1906	1868	1837	1837
query48	447	355	350	350
query49	1237	345	347	345
query50	770	374	379	374
query51	6656	6617	6588	6588
query52	121	97	87	87
query53	339	281	280	280
query54	327	275	255	255
query55	84	76	80	76
query56	247	231	242	231
query57	1208	1152	1147	1147
query58	228	208	209	208
query59	2901	2538	2617	2538
query60	286	258	271	258
query61	127	113	127	113
query62	667	443	455	443
query63	307	281	286	281
query64	6945	3970	3956	3956
query65	3060	3022	3046	3022
query66	1456	361	348	348
query67	15573	14863	14889	14863
query68	9090	522	528	522
query69	625	398	386	386
query70	1263	1194	1166	1166
query71	518	278	278	278
query72	6330	2763	2589	2589
query73	1030	312	312	312
query74	8632	6693	6724	6693
query75	4200	2829	2831	2829
query76	5340	881	891	881
query77	652	261	254	254
query78	11016	10270	10139	10139
query79	10440	516	517	516
query80	2020	395	382	382
query81	514	209	223	209
query82	742	205	206	205
query83	214	144	147	144
query84	284	78	83	78
query85	1433	315	314	314
query86	406	319	321	319
query87	3763	3637	3551	3551
query88	4531	2284	2271	2271
query89	514	358	361	358
query90	1936	173	177	173
query91	166	138	153	138
query92	65	46	49	46
query93	7074	496	486	486
query94	1194	175	181	175
query95	436	333	331	331
query96	620	276	259	259
query97	3088	2896	2880	2880
query98	226	211	207	207
query99	1211	923	920	920
Total cold run time: 322476 ms
Total hot run time: 187092 ms

doris-robot · 2024-03-25T07:49:25Z

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit ad1061fb17860316e118109a590b7bed084e877c with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 20.9 seconds inserted 10000000 Rows, about 478K ops/s

feiniaofeiafei · 2024-03-25T09:38:20Z

run buildall

doris-robot · 2024-03-25T10:03:09Z

TPC-H: Total hot run time: 38245 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cffe9be75e60a5a44b5a9e6e3dfc604422dac50b, data reload: false
------ Round 1 ----------------------------------
q1	17998	4388	4183	4183
q2	2122	159	156	156
q3	10581	1159	1243	1159
q4	10231	810	881	810
q5	7488	3099	2976	2976
q6	205	128	125	125
q7	1060	591	581	581
q8	9332	2046	2008	2008
q9	7259	6660	6637	6637
q10	8390	3461	3554	3461
q11	424	220	214	214
q12	372	213	197	197
q13	17780	2838	2876	2838
q14	230	196	200	196
q15	513	453	464	453
q16	461	368	372	368
q17	968	555	603	555
q18	7273	6568	6445	6445
q19	1553	1455	1531	1455
q20	551	267	249	249
q21	3651	2985	2887	2887
q22	342	292	294	292
Total cold run time: 108784 ms
Total hot run time: 38245 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4093	4050	4101	4050
q2	327	230	225	225
q3	3009	2882	2861	2861
q4	1853	1562	1605	1562
q5	5321	5338	5364	5338
q6	193	116	118	116
q7	2244	1884	1860	1860
q8	3166	3316	3285	3285
q9	8714	8693	8748	8693
q10	3816	3789	3796	3789
q11	549	458	442	442
q12	732	548	503	503
q13	16919	2871	2872	2871
q14	269	243	272	243
q15	494	460	456	456
q16	477	433	406	406
q17	1748	1509	1475	1475
q18	7560	7242	7084	7084
q19	1610	1487	1578	1487
q20	1899	1745	1716	1716
q21	4846	4693	4852	4693
q22	541	438	438	438
Total cold run time: 70380 ms
Total hot run time: 53593 ms

doris-robot · 2024-03-25T10:15:13Z

TPC-DS: Total hot run time: 186656 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cffe9be75e60a5a44b5a9e6e3dfc604422dac50b, data reload: false
query1	945	374	356	356
query2	7372	1933	1915	1915
query3	6713	212	218	212
query4	31862	21439	21311	21311
query5	4339	430	420	420
query6	272	176	165	165
query7	4629	287	297	287
query8	229	169	175	169
query9	9397	2258	2249	2249
query10	563	250	283	250
query11	14860	14377	14477	14377
query12	134	90	91	90
query13	1632	405	413	405
query14	13140	11387	11078	11078
query15	253	200	198	198
query16	8168	259	259	259
query17	1946	576	561	561
query18	2109	296	288	288
query19	325	157	156	156
query20	99	93	87	87
query21	214	131	136	131
query22	5017	4766	4778	4766
query23	33571	32649	32763	32649
query24	11543	2886	2870	2870
query25	657	386	385	385
query26	1744	154	160	154
query27	2977	354	346	346
query28	7824	1869	1826	1826
query29	1017	665	636	636
query30	310	150	151	150
query31	988	735	723	723
query32	95	61	60	60
query33	835	271	249	249
query34	983	483	507	483
query35	822	618	601	601
query36	1001	900	888	888
query37	172	81	78	78
query38	3572	3431	3424	3424
query39	1506	1454	1436	1436
query40	294	122	112	112
query41	55	46	52	46
query42	108	96	96	96
query43	488	444	438	438
query44	1234	724	721	721
query45	290	270	260	260
query46	1126	710	711	710
query47	1907	1840	1837	1837
query48	443	360	360	360
query49	1235	346	338	338
query50	771	382	371	371
query51	6642	6578	6623	6578
query52	102	94	90	90
query53	351	271	284	271
query54	338	251	257	251
query55	86	81	81	81
query56	264	239	231	231
query57	1235	1127	1139	1127
query58	233	205	220	205
query59	2927	2606	2565	2565
query60	272	243	267	243
query61	96	96	93	93
query62	672	451	447	447
query63	312	276	272	272
query64	6811	3944	4021	3944
query65	3098	3033	3054	3033
query66	1403	367	353	353
query67	15273	15038	15025	15025
query68	6567	510	520	510
query69	607	373	387	373
query70	1181	1169	1209	1169
query71	490	279	271	271
query72	6325	2726	2568	2568
query73	717	311	318	311
query74	8366	6652	6603	6603
query75	3958	2855	2818	2818
query76	4373	877	894	877
query77	599	256	254	254
query78	10845	10209	10069	10069
query79	8193	506	522	506
query80	1423	402	400	400
query81	527	216	215	215
query82	878	205	208	205
query83	208	148	148	148
query84	292	77	83	77
query85	1460	368	367	367
query86	426	311	303	303
query87	3757	3560	3532	3532
query88	4771	2306	2278	2278
query89	522	373	381	373
query90	2023	182	184	182
query91	182	153	152	152
query92	66	53	49	49
query93	6312	504	483	483
query94	1135	190	187	187
query95	444	347	342	342
query96	606	270	279	270
query97	3083	2875	2910	2875
query98	243	212	204	204
query99	1235	909	899	899
Total cold run time: 313715 ms
Total hot run time: 186656 ms

doris-robot · 2024-03-25T10:18:28Z

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit cffe9be75e60a5a44b5a9e6e3dfc604422dac50b with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 22.7 seconds inserted 10000000 Rows, about 440K ops/s

feiniaofeiafei · 2024-03-26T08:36:13Z

run buildall

doris-robot · 2024-03-26T09:01:35Z

TPC-H: Total hot run time: 38849 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6b47b8798d240979ade7c65b65d4b0cce7f73613, data reload: false
------ Round 1 ----------------------------------
q1	17729	4506	4300	4300
q2	3281	165	162	162
q3	11382	1186	1263	1186
q4	10816	829	797	797
q5	7667	3124	3107	3107
q6	207	127	126	126
q7	1090	629	610	610
q8	10075	2092	2078	2078
q9	7302	6758	6761	6758
q10	9541	3471	3578	3471
q11	426	228	225	225
q12	367	211	205	205
q13	17795	2855	2876	2855
q14	243	207	208	207
q15	502	466	468	466
q16	486	378	376	376
q17	965	544	657	544
q18	7255	6465	6545	6465
q19	1556	1510	1425	1425
q20	532	254	271	254
q21	3554	3042	2940	2940
q22	349	302	292	292
Total cold run time: 113120 ms
Total hot run time: 38849 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4205	4125	4116	4116
q2	331	230	242	230
q3	3076	2894	2908	2894
q4	1873	1590	1578	1578
q5	5302	5371	5351	5351
q6	193	118	119	118
q7	2258	1874	1864	1864
q8	3172	3314	3305	3305
q9	8761	8720	8730	8720
q10	3843	3822	3782	3782
q11	543	440	441	440
q12	700	523	532	523
q13	16572	2855	2892	2855
q14	279	250	260	250
q15	493	461	453	453
q16	469	411	416	411
q17	1741	1513	1499	1499
q18	7413	7378	7095	7095
q19	1634	1515	1533	1515
q20	1914	1753	1723	1723
q21	4846	4602	4642	4602
q22	547	464	465	464
Total cold run time: 70165 ms
Total hot run time: 53788 ms

doris-robot · 2024-03-26T09:13:29Z

TPC-DS: Total hot run time: 181670 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6b47b8798d240979ade7c65b65d4b0cce7f73613, data reload: false
query1	947	369	346	346
query2	6520	2014	1870	1870
query3	6717	216	218	216
query4	31930	21283	21273	21273
query5	4323	392	390	390
query6	272	178	169	169
query7	4642	288	292	288
query8	221	184	181	181
query9	9114	2271	2250	2250
query10	560	261	261	261
query11	15238	14188	14217	14188
query12	138	91	85	85
query13	1630	418	428	418
query14	10047	7948	7738	7738
query15	257	192	193	192
query16	8247	261	265	261
query17	1968	588	557	557
query18	2106	292	285	285
query19	362	166	164	164
query20	93	88	91	88
query21	203	130	126	126
query22	5067	4859	4884	4859
query23	33690	32835	32794	32794
query24	11657	2903	2817	2817
query25	655	404	396	396
query26	1786	163	158	158
query27	2953	345	356	345
query28	7456	1905	1868	1868
query29	1026	665	623	623
query30	308	155	157	155
query31	950	732	764	732
query32	93	57	56	56
query33	770	259	251	251
query34	1051	496	478	478
query35	846	621	600	600
query36	1019	885	874	874
query37	182	65	69	65
query38	3544	3386	3424	3386
query39	1485	1491	1403	1403
query40	298	116	112	112
query41	50	48	48	48
query42	118	98	99	98
query43	500	453	455	453
query44	1151	731	750	731
query45	269	267	271	267
query46	1125	727	723	723
query47	1972	1865	1846	1846
query48	455	369	362	362
query49	1242	371	346	346
query50	770	384	376	376
query51	6727	6673	6604	6604
query52	112	96	88	88
query53	348	279	276	276
query54	325	242	246	242
query55	88	77	81	77
query56	248	226	230	226
query57	1217	1141	1147	1141
query58	241	209	213	209
query59	2831	2792	2555	2555
query60	278	250	250	250
query61	115	114	129	114
query62	653	432	467	432
query63	305	277	275	275
query64	6431	4041	3985	3985
query65	3162	3041	3057	3041
query66	1424	366	360	360
query67	15389	14783	14788	14783
query68	8408	543	543	543
query69	636	389	387	387
query70	1258	1172	1182	1172
query71	500	265	268	265
query72	6405	2719	2535	2535
query73	744	321	322	321
query74	6913	6409	6533	6409
query75	4015	2201	2217	2201
query76	5238	870	863	863
query77	637	270	257	257
query78	10877	10191	10052	10052
query79	10250	520	529	520
query80	1727	393	369	369
query81	517	217	213	213
query82	844	86	85	85
query83	212	149	147	147
query84	287	77	81	77
query85	1474	323	315	315
query86	427	289	280	280
query87	3686	3486	3551	3486
query88	4923	2366	2370	2366
query89	505	363	358	358
query90	2046	172	173	172
query91	168	136	140	136
query92	60	46	46	46
query93	6734	500	484	484
query94	1194	179	174	174
query95	429	329	324	324
query96	594	278	276	276
query97	2669	2532	2502	2502
query98	225	219	206	206
query99	1241	920	903	903
Total cold run time: 313760 ms
Total hot run time: 181670 ms

doris-robot · 2024-03-26T09:16:43Z

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 6b47b8798d240979ade7c65b65d4b0cce7f73613 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 22.3 seconds inserted 10000000 Rows, about 448K ops/s

morrySnow · 2024-03-26T12:40:18Z

add description

feiniaofeiafei · 2024-03-26T13:31:01Z

run buildall

doris-robot · 2024-03-26T14:13:54Z

TPC-H: Total hot run time: 37716 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d046f38ab411f63a8f44f3179014262d4b22ebe5, data reload: false
------ Round 1 ----------------------------------
q1	17602	4322	4112	4112
q2	2111	158	152	152
q3	10581	1122	1182	1122
q4	10237	715	763	715
q5	7484	3027	2987	2987
q6	205	123	123	123
q7	1034	573	552	552
q8	9343	1977	1979	1977
q9	7178	6588	6537	6537
q10	8437	3404	3496	3404
q11	434	224	214	214
q12	444	204	200	200
q13	17779	2830	2882	2830
q14	238	201	204	201
q15	501	471	452	452
q16	488	374	368	368
q17	949	550	588	550
q18	7129	6407	6461	6407
q19	5548	1427	1495	1427
q20	546	258	244	244
q21	3616	2994	2848	2848
q22	341	304	294	294
Total cold run time: 112225 ms
Total hot run time: 37716 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4161	4083	4086	4083
q2	331	227	236	227
q3	2979	2839	2849	2839
q4	1857	1509	1580	1509
q5	5275	5305	5357	5305
q6	192	118	120	118
q7	2233	1841	1825	1825
q8	3141	3294	3275	3275
q9	8654	8662	8648	8648
q10	3782	3760	3715	3715
q11	543	450	454	450
q12	714	558	542	542
q13	16924	2838	2851	2838
q14	285	248	265	248
q15	497	458	454	454
q16	474	433	441	433
q17	1715	1500	1451	1451
q18	7457	7191	7058	7058
q19	1605	1538	1543	1538
q20	1908	1744	1726	1726
q21	4849	4700	4551	4551
q22	516	452	441	441
Total cold run time: 70092 ms
Total hot run time: 53274 ms

doris-robot · 2024-03-26T14:25:41Z

TPC-DS: Total hot run time: 181052 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d046f38ab411f63a8f44f3179014262d4b22ebe5, data reload: false
query1	940	371	365	365
query2	6540	1905	1822	1822
query3	6710	205	204	204
query4	31828	21232	21252	21232
query5	4213	389	391	389
query6	265	185	183	183
query7	4647	292	289	289
query8	227	167	172	167
query9	9458	2353	2318	2318
query10	560	245	249	245
query11	17267	14223	14187	14187
query12	142	89	84	84
query13	1628	418	422	418
query14	9375	7298	7568	7298
query15	232	194	201	194
query16	8117	269	263	263
query17	1953	581	557	557
query18	2082	290	279	279
query19	254	155	155	155
query20	93	85	85	85
query21	202	134	130	130
query22	4996	4846	4823	4823
query23	33706	32861	32849	32849
query24	11085	2852	2915	2852
query25	631	393	385	385
query26	1257	153	157	153
query27	3037	358	377	358
query28	7585	1934	1924	1924
query29	922	643	648	643
query30	303	147	147	147
query31	983	731	739	731
query32	96	57	56	56
query33	764	254	252	252
query34	1039	487	483	483
query35	844	604	599	599
query36	1037	888	900	888
query37	126	64	67	64
query38	3570	3443	3459	3443
query39	1444	1438	1415	1415
query40	209	113	116	113
query41	53	47	47	47
query42	106	94	100	94
query43	465	447	451	447
query44	1195	713	720	713
query45	276	268	257	257
query46	1119	720	698	698
query47	1922	1838	1863	1838
query48	439	364	362	362
query49	1135	346	338	338
query50	753	367	379	367
query51	6749	6624	6632	6624
query52	111	89	92	89
query53	350	275	271	271
query54	299	240	242	240
query55	87	78	79	78
query56	250	235	234	234
query57	1209	1150	1157	1150
query58	231	215	212	212
query59	2752	2475	2484	2475
query60	282	245	252	245
query61	95	91	91	91
query62	674	465	460	460
query63	301	268	268	268
query64	5662	3995	3915	3915
query65	3126	3011	3029	3011
query66	872	365	356	356
query67	15338	14973	14657	14657
query68	6656	541	520	520
query69	593	382	370	370
query70	1218	1114	1153	1114
query71	465	265	256	256
query72	6647	2703	2563	2563
query73	719	313	320	313
query74	7934	6345	6343	6343
query75	3151	2237	2165	2165
query76	3828	911	922	911
query77	626	255	241	241
query78	10920	10150	10165	10150
query79	7641	526	528	526
query80	1906	380	356	356
query81	542	216	220	216
query82	1596	84	86	84
query83	346	144	147	144
query84	292	81	79	79
query85	1587	317	314	314
query86	484	317	297	297
query87	3732	3531	3550	3531
query88	5045	2390	2372	2372
query89	493	377	371	371
query90	1967	178	178	178
query91	177	148	149	148
query92	62	50	56	50
query93	5987	510	495	495
query94	1192	185	185	185
query95	447	330	336	330
query96	607	274	279	274
query97	2660	2511	2462	2462
query98	219	227	212	212
query99	1221	930	903	903
Total cold run time: 307178 ms
Total hot run time: 181052 ms

doris-robot · 2024-03-26T14:34:04Z

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit d046f38ab411f63a8f44f3179014262d4b22ebe5 with default session variables
Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 13.5 seconds inserted 10000000 Rows, about 740K ops/s

github-actions · 2024-03-29T06:51:02Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-03-29T06:51:04Z

PR approved by anyone and no changes requested.

feiniaofeiafei · 2024-04-02T08:43:21Z

run buildall

doris-robot · 2024-04-02T09:04:00Z

TPC-H: Total hot run time: 39522 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d232508b98153bc02df441a02569f65e022c2f4d, data reload: false
------ Round 1 ----------------------------------
q1	17977	4227	4172	4172
q2	2475	197	190	190
q3	11357	1342	1452	1342
q4	10847	911	1035	911
q5	8041	2998	2922	2922
q6	218	135	132	132
q7	1123	624	625	624
q8	9400	2045	2039	2039
q9	7445	6743	6729	6729
q10	8470	3500	3487	3487
q11	423	249	233	233
q12	389	224	212	212
q13	17946	2935	2938	2935
q14	274	244	244	244
q15	530	492	474	474
q16	501	396	374	374
q17	954	929	896	896
q18	7235	6541	6388	6388
q19	1616	1525	1532	1525
q20	595	329	316	316
q21	3508	3083	3078	3078
q22	364	299	308	299
Total cold run time: 111688 ms
Total hot run time: 39522 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4028	4053	4025	4025
q2	330	214	218	214
q3	2948	2929	2933	2929
q4	1883	1845	1840	1840
q5	5213	5239	5221	5221
q6	206	125	127	125
q7	2228	1809	1812	1809
q8	3204	3288	3276	3276
q9	9085	9077	9046	9046
q10	3731	3796	3806	3796
q11	536	448	444	444
q12	703	530	545	530
q13	11565	2891	2930	2891
q14	303	269	260	260
q15	506	482	470	470
q16	451	399	409	399
q17	1712	1682	1635	1635
q18	7592	7170	7213	7170
q19	1624	1631	1636	1631
q20	1931	1733	1727	1727
q21	4906	4745	4734	4734
q22	491	416	420	416
Total cold run time: 65176 ms
Total hot run time: 54588 ms

doris-robot · 2024-04-02T09:15:32Z

TPC-DS: Total hot run time: 180809 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d232508b98153bc02df441a02569f65e022c2f4d, data reload: false
query1	899	1121	1112	1112
query2	6485	1968	1827	1827
query3	6670	221	226	221
query4	25380	21396	21328	21328
query5	4195	396	396	396
query6	274	184	187	184
query7	4591	305	301	301
query8	232	186	183	183
query9	8454	2271	2255	2255
query10	577	271	261	261
query11	15190	14592	14577	14577
query12	144	100	98	98
query13	1634	376	386	376
query14	8684	6921	6960	6921
query15	212	187	187	187
query16	7162	282	284	282
query17	986	603	585	585
query18	1911	299	284	284
query19	211	167	168	167
query20	100	97	98	97
query21	204	140	138	138
query22	4938	4788	4733	4733
query23	33520	32471	32636	32471
query24	12012	3110	3144	3110
query25	673	383	396	383
query26	1895	168	164	164
query27	2942	333	331	331
query28	6808	1866	1842	1842
query29	1363	587	584	584
query30	303	164	163	163
query31	997	715	736	715
query32	98	62	60	60
query33	702	267	248	248
query34	996	477	495	477
query35	845	707	716	707
query36	1033	847	866	847
query37	279	80	84	80
query38	3574	3357	3358	3357
query39	1575	1520	1533	1520
query40	308	140	137	137
query41	51	49	46	46
query42	116	112	106	106
query43	439	403	417	403
query44	1091	718	708	708
query45	280	261	264	261
query46	1069	813	778	778
query47	1865	1804	1777	1777
query48	367	317	309	309
query49	1175	366	358	358
query50	791	400	405	400
query51	6830	6694	6737	6694
query52	114	96	98	96
query53	359	300	296	296
query54	327	249	255	249
query55	86	80	79	79
query56	252	234	225	225
query57	1204	1100	1123	1100
query58	254	235	230	230
query59	2551	2409	2358	2358
query60	283	239	252	239
query61	116	112	107	107
query62	704	479	467	467
query63	325	289	288	288
query64	6424	3090	3081	3081
query65	3065	3012	3022	3012
query66	1452	340	340	340
query67	15407	14694	14699	14694
query68	5133	563	580	563
query69	494	328	322	322
query70	1187	1091	1110	1091
query71	446	287	282	282
query72	6288	2731	2477	2477
query73	709	330	321	321
query74	6723	6341	6349	6341
query75	3024	2302	2277	2277
query76	3206	1044	1191	1044
query77	398	255	252	252
query78	10858	10267	10036	10036
query79	8366	542	521	521
query80	2001	420	420	420
query81	540	241	245	241
query82	1605	105	101	101
query83	308	163	162	162
query84	273	88	89	88
query85	2020	300	288	288
query86	495	310	288	288
query87	3664	3533	3446	3446
query88	4329	2338	2337	2337
query89	504	376	377	376
query90	2024	173	181	173
query91	137	112	105	105
query92	65	52	50	50
query93	6316	532	526	526
query94	1225	197	196	196
query95	425	325	321	321
query96	599	269	268	268
query97	2666	2480	2464	2464
query98	247	220	209	209
query99	1313	862	813	813
Total cold run time: 293641 ms
Total hot run time: 180809 ms

doris-robot · 2024-04-02T09:20:55Z

ClickBench: Total hot run time: 30.01 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d232508b98153bc02df441a02569f65e022c2f4d, data reload: false
query1	0.04	0.03	0.03
query2	0.07	0.03	0.04
query3	0.23	0.05	0.05
query4	1.68	0.07	0.06
query5	0.49	0.49	0.49
query6	1.14	0.64	0.64
query7	0.02	0.02	0.01
query8	0.05	0.05	0.05
query9	0.56	0.51	0.51
query10	0.54	0.57	0.57
query11	0.15	0.11	0.11
query12	0.13	0.12	0.12
query13	0.61	0.59	0.58
query14	0.77	0.78	0.77
query15	0.85	0.85	0.84
query16	0.35	0.36	0.36
query17	0.97	1.00	0.99
query18	0.23	0.26	0.25
query19	1.86	1.75	1.74
query20	0.02	0.01	0.01
query21	15.42	0.73	0.70
query22	3.56	5.49	1.53
query23	17.59	1.19	1.10
query24	1.84	0.22	0.24
query25	0.15	0.09	0.08
query26	0.29	0.18	0.19
query27	0.09	0.09	0.09
query28	13.38	0.95	0.94
query29	12.52	3.47	3.46
query30	0.26	0.06	0.06
query31	2.85	0.40	0.39
query32	3.28	0.48	0.47
query33	2.90	2.88	2.81
query34	15.51	4.33	4.32
query35	4.36	4.37	4.35
query36	0.68	0.48	0.47
query37	0.20	0.17	0.17
query38	0.17	0.17	0.16
query39	0.04	0.04	0.04
query40	0.20	0.15	0.15
query41	0.09	0.04	0.05
query42	0.06	0.05	0.04
query43	0.05	0.03	0.03
Total cold run time: 106.25 s
Total hot run time: 30.01 s

doris-robot · 2024-04-02T09:24:03Z

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit d232508b98153bc02df441a02569f65e022c2f4d with default session variables
Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 16.8 seconds inserted 10000000 Rows, about 595K ops/s

github-actions · 2024-04-03T06:36:55Z

PR approved by at least one committer and no changes requested.

) modify the bind logical to make the order by has same behavior with mysql when sort child is aggregate. when an order by Expr has aggregate function, all slots in this order by Expr should bind the LogicalAggregate non-AggFunction outputs first, then bind the LogicalAggregate Child e.g. select 2*abs(sum(c1)) as c1, c1,sum(c1)+c1 from t_order_by_bind_priority group by c1 order by sum(c1)+c1 asc; in this sql, the two c1 in order by all bind to the c1 in t_order_by_bind_priority

) Do same job with pr #32758 and pr #33843. Because the master branch2.0 differ in binding order by expressions. So this pr is not a cherry-pick, but actually does same job. For each order by expression: If it does not have aggregate functions, firstly bind expression from aggregate outputs. If not found, then bind expression from aggregate child outputs. If it has aggregate functions, firstly bind expression from aggregate outputs which do not have aggregate functions. If not found, then bind expression from aggregate child outputs. Co-authored-by: feiniaofeiafei <moailing@selectdb.com>

…che#34606) Do same job with pr apache#32758 and pr apache#33843. Because the master branch2.0 differ in binding order by expressions. So this pr is not a cherry-pick, but actually does same job. For each order by expression: If it does not have aggregate functions, firstly bind expression from aggregate outputs. If not found, then bind expression from aggregate child outputs. If it has aggregate functions, firstly bind expression from aggregate outputs which do not have aggregate functions. If not found, then bind expression from aggregate child outputs. Co-authored-by: feiniaofeiafei <moailing@selectdb.com>

…che#32758) modify the bind logical to make the order by has same behavior with mysql when sort child is aggregate. when an order by Expr has aggregate function, all slots in this order by Expr should bind the LogicalAggregate non-AggFunction outputs first, then bind the LogicalAggregate Child e.g. select 2*abs(sum(c1)) as c1, c1,sum(c1)+c1 from t_order_by_bind_priority group by c1 order by sum(c1)+c1 asc; in this sql, the two c1 in order by all bind to the c1 in t_order_by_bind_priority

xiaokang added the dev/2.0.x label Mar 25, 2024

924060929 reviewed Mar 26, 2024
View reviewed changes

Comment threadfe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindExpression.java

feiniaofeiafei requested a review from 924060929 March 29, 2024 06:28

924060929 previously approved these changes Mar 29, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Mar 29, 2024

github-actionsBot added the reviewed label Mar 29, 2024

starocean999 previously approved these changes Apr 1, 2024
View reviewed changes

feiniaofeiafei added 3 commits April 2, 2024 16:12

[Fix](nereids) modify the binding aggregate function in order by
c9d1fbc

[Fix](nereids) modify the binding aggregate function in order by
b939f98

[Fix](nereids) modify the binding aggregate function in order by
5f15b00

feiniaofeiafei added 4 commits April 2, 2024 16:13

[Fix](nereids) modify the binding aggregate function in order by
c26ea3a

[Fix](nereids) modify the binding aggregate function in order by
f1c6b76

[Fix](nereids) modify the binding aggregate function in order by
4c2f7b2

[Fix](nereids) modify the binding aggregate function in order by
d232508

feiniaofeiafei dismissed stale reviews from starocean999 and 924060929 via d232508April 2, 2024 08:42

feiniaofeiafei force-pushed the sortbind branch from d046f38 to d232508Compare April 2, 2024 08:42

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Apr 2, 2024

feiniaofeiafei requested review from 924060929 and starocean999 April 3, 2024 06:28

924060929 approved these changes Apr 3, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 3, 2024

starocean999 approved these changes Apr 3, 2024
View reviewed changes

morrySnow merged commit d58c7a8 into apache:masterApr 3, 2024

morrySnow removed the dev/2.0.x label Apr 15, 2024

feiniaofeiafei mentioned this pull request May 10, 2024
[Fix](nereids) modify the binding aggregate function in order by #34606
Merged

morrySnow added the dev/2.0.11-merged label May 16, 2024

Uh oh!

Conversation

feiniaofeiafei commented Mar 25, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

doris-robot commented Mar 25, 2024

Uh oh!

feiniaofeiafei commented Mar 25, 2024

Uh oh!

doris-robot commented Mar 25, 2024

Uh oh!

doris-robot commented Mar 25, 2024

Uh oh!

doris-robot commented Mar 25, 2024

Uh oh!

feiniaofeiafei commented Mar 25, 2024

Uh oh!

doris-robot commented Mar 25, 2024

Uh oh!

doris-robot commented Mar 25, 2024

Uh oh!

doris-robot commented Mar 25, 2024

Uh oh!

feiniaofeiafei commented Mar 26, 2024

Uh oh!

doris-robot commented Mar 26, 2024

Uh oh!

doris-robot commented Mar 26, 2024

Uh oh!

doris-robot commented Mar 26, 2024

Uh oh!

morrySnow commented Mar 26, 2024

Uh oh!

Uh oh!

feiniaofeiafei commented Mar 26, 2024

Uh oh!

doris-robot commented Mar 26, 2024

Uh oh!

doris-robot commented Mar 26, 2024

Uh oh!

doris-robot commented Mar 26, 2024

Uh oh!

github-actionsBot commented Mar 29, 2024

Uh oh!

github-actionsBot commented Mar 29, 2024

Uh oh!

feiniaofeiafei commented Apr 2, 2024

Uh oh!

doris-robot commented Apr 2, 2024

Uh oh!

doris-robot commented Apr 2, 2024

Uh oh!

doris-robot commented Apr 2, 2024

Uh oh!

doris-robot commented Apr 2, 2024

Uh oh!

github-actionsBot commented Apr 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

feiniaofeiafei commented Mar 25, 2024•
edited
Loading