[Fix](nereids) modify the binding aggregate function in order by by feiniaofeiafei · Pull Request #34606 · apache/doris

feiniaofeiafei · 2024-05-09T10:22:22Z

Do same job with pr #32758 and pr #33843.
Because the master branch2.0 differ in binding order by expressions. So this pr is not a cherry-pick, but actually does same job.
For each order by expression:
If it does not have aggregate functions, firstly bind expression from aggregate outputs. If not found, then bind expression from aggregate child outputs.
If it has aggregate functions, firstly bind expression from aggregate outputs which do not have aggregate functions. If not found, then bind expression from aggregate child outputs.

…ranch2.0

doris-robot · 2024-05-09T10:22:27Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

feiniaofeiafei · 2024-05-09T12:28:26Z

run buildall

…ranch2.0

feiniaofeiafei · 2024-05-09T15:25:08Z

run buildall

doris-robot · 2024-05-09T15:46:32Z

TPC-H: Total hot run time: 49574 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ad12fe18bfd0d315479f6dd8a48d81387796eb92, data reload: false
------ Round 1 ----------------------------------
q1	17963	4454	4323	4323
q2	2033	153	152	152
q3	10489	1869	1951	1869
q4	10327	1244	1340	1244
q5	8432	3923	3950	3923
q6	243	125	129	125
q7	2053	1618	1577	1577
q8	9485	2740	2736	2736
q9	13775	10181	10274	10181
q10	8696	3554	3507	3507
q11	414	241	245	241
q12	467	309	313	309
q13	18337	3952	4011	3952
q14	348	326	324	324
q15	501	471	466	466
q16	657	574	581	574
q17	1153	965	947	947
q18	7157	6901	6838	6838
q19	1711	1562	1517	1517
q20	546	298	291	291
q21	4447	4167	4084	4084
q22	499	395	394	394
Total cold run time: 119733 ms
Total hot run time: 49574 ms
----- Round 2, with runtime_filter_mode=off -----
q1	4299	4279	4299	4279
q2	324	221	224	221
q3	4167	4162	4114	4114
q4	2757	2737	2738	2737
q5	7189	7055	7072	7055
q6	238	122	124	122
q7	3263	2801	2802	2801
q8	4347	4434	4462	4434
q9	16838	16761	16813	16761
q10	4206	4290	4317	4290
q11	767	671	659	659
q12	1013	878	845	845
q13	6671	3766	3741	3741
q14	465	421	412	412
q15	502	461	455	455
q16	748	697	707	697
q17	3803	3769	3883	3769
q18	8781	8738	8774	8738
q19	1726	1698	1719	1698
q20	2347	2130	2153	2130
q21	8467	8453	8357	8357
q22	993	975	943	943
Total cold run time: 83911 ms
Total hot run time: 79258 ms

doris-robot · 2024-05-09T15:59:13Z

TPC-DS: Total hot run time: 204308 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ad12fe18bfd0d315479f6dd8a48d81387796eb92, data reload: false
query1	916	395	374	374
query2	6543	2929	2626	2626
query3	6914	207	204	204
query4	20363	17888	17884	17884
query5	19724	6501	6476	6476
query6	288	224	221	221
query7	4227	303	318	303
query8	265	245	252	245
query9	3174	2737	2674	2674
query10	418	311	313	311
query11	11433	10706	10666	10666
query12	121	77	72	72
query13	5577	709	668	668
query14	17879	13436	13447	13436
query15	352	214	233	214
query16	6440	292	255	255
query17	1544	1462	883	883
query18	2251	402	412	402
query19	206	157	158	157
query20	83	77	86	77
query21	188	97	94	94
query22	5308	5157	5202	5157
query23	32406	31827	32082	31827
query24	6840	6492	6522	6492
query25	515	428	419	419
query26	528	171	165	165
query27	1897	305	297	297
query28	6125	2388	2354	2354
query29	2966	2756	2757	2756
query30	249	169	169	169
query31	926	741	770	741
query32	67	65	62	62
query33	390	250	248	248
query34	855	468	495	468
query35	1120	892	914	892
query36	1230	1498	1314	1314
query37	86	61	60	60
query38	3081	2928	2959	2928
query39	1391	1360	1330	1330
query40	207	105	90	90
query41	44	36	35	35
query42	87	85	78	78
query43	713	697	677	677
query44	1159	721	723	721
query45	245	233	232	232
query46	1214	975	976	975
query47	1919	1761	1860	1761
query48	1036	729	718	718
query49	629	372	360	360
query50	881	645	614	614
query51	4748	4660	4670	4660
query52	101	91	86	86
query53	443	328	322	322
query54	2650	2433	2473	2433
query55	99	87	87	87
query56	225	219	214	214
query57	1172	1101	1125	1101
query58	207	198	187	187
query59	4390	4163	4171	4163
query60	226	203	204	203
query61	85	84	82	82
query62	774	503	480	480
query63	485	345	349	345
query64	2561	1491	1436	1436
query65	3621	3600	3550	3550
query66	777	375	380	375
query67	17412	16277	15893	15893
query68	9580	678	636	636
query69	576	366	347	347
query70	1627	1349	1519	1349
query71	431	293	316	293
query72	6451	3487	3418	3418
query73	744	332	332	332
query74	6322	5787	5864	5787
query75	5391	3700	3700	3700
query76	5970	1179	1183	1179
query77	1016	265	261	261
query78	12671	11579	17272	11579
query79	5074	636	630	630
query80	801	411	393	393
query81	487	232	236	232
query82	263	94	102	94
query83	175	146	129	129
query84	249	68	70	68
query85	852	305	294	294
query86	337	297	302	297
query87	3172	3094	3056	3056
query88	3666	2342	2358	2342
query89	338	292	319	292
query90	1941	211	210	210
query91	186	134	145	134
query92	58	52	58	52
query93	923	579	534	534
query94	701	202	206	202
query95	1101	1074	1056	1056
query96	636	322	336	322
query97	6503	6406	6294	6294
query98	193	179	176	176
query99	2838	862	821	821
Total cold run time: 304269 ms
Total hot run time: 204308 ms

doris-robot · 2024-05-09T16:04:41Z

ClickBench: Total hot run time: 30.51 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ad12fe18bfd0d315479f6dd8a48d81387796eb92, data reload: false
query1	0.02	0.02	0.02
query2	0.07	0.02	0.02
query3	0.25	0.04	0.03
query4	1.83	0.05	0.06
query5	0.53	0.52	0.50
query6	1.23	0.63	0.61
query7	0.01	0.01	0.01
query8	0.03	0.02	0.03
query9	0.52	0.49	0.49
query10	0.53	0.53	0.53
query11	0.12	0.09	0.08
query12	0.12	0.08	0.08
query13	0.62	0.62	0.61
query14	0.78	0.79	0.79
query15	0.78	0.76	0.75
query16	0.36	0.36	0.35
query17	1.01	1.00	0.99
query18	0.22	0.26	0.24
query19	1.89	1.80	1.83
query20	0.01	0.01	0.01
query21	15.48	0.57	0.54
query22	2.26	2.81	1.67
query23	17.41	0.96	0.86
query24	8.45	0.99	0.90
query25	0.43	0.14	0.05
query26	0.80	0.14	0.16
query27	0.05	0.04	0.03
query28	4.86	0.73	0.78
query29	12.62	2.26	2.35
query30	0.58	0.53	0.53
query31	2.81	0.39	0.37
query32	3.40	0.49	0.49
query33	3.05	3.08	3.09
query34	15.25	4.80	4.80
query35	4.85	4.86	4.83
query36	1.05	1.01	1.02
query37	0.06	0.04	0.04
query38	0.04	0.02	0.02
query39	0.02	0.02	0.01
query40	0.16	0.14	0.14
query41	0.06	0.01	0.01
query42	0.02	0.01	0.01
query43	0.02	0.02	0.01
Total cold run time: 104.66 s
Total hot run time: 30.51 s

doris-robot · 2024-05-09T16:07:55Z

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit ad12fe18bfd0d315479f6dd8a48d81387796eb92 with default session variables
Stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 21.4 seconds inserted 10000000 Rows, about 467K ops/s

feiniaofeiafei · 2024-05-10T02:43:11Z

run feut

github-actions · 2024-05-10T04:03:38Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-05-10T04:03:40Z

PR approved by anyone and no changes requested.

…che#34606) Do same job with pr apache#32758 and pr apache#33843. Because the master branch2.0 differ in binding order by expressions. So this pr is not a cherry-pick, but actually does same job. For each order by expression: If it does not have aggregate functions, firstly bind expression from aggregate outputs. If not found, then bind expression from aggregate child outputs. If it has aggregate functions, firstly bind expression from aggregate outputs which do not have aggregate functions. If not found, then bind expression from aggregate child outputs. Co-authored-by: feiniaofeiafei <moailing@selectdb.com>

[Fix](nereids) modify the binding aggregate function in order by in b…
4bed0ae
…ranch2.0

github-actionsBot added area/nereids kind/test labels May 9, 2024

[Fix](nereids) modify the binding aggregate function in order by in b…
ad12fe1
…ranch2.0

924060929 approved these changes May 10, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label May 10, 2024

github-actionsBot added the reviewed label May 10, 2024

morrySnow changed the title ~~[Fix](nereids) modify the binding aggregate function in order by in branch2.0~~[Fix](nereids) modify the binding aggregate function in order byMay 10, 2024

morrySnow merged commit b055552 into apache:branch-2.0May 16, 2024

Navigation Menu

Uh oh!

[Fix](nereids) modify the binding aggregate function in order by - #34606

[Fix](nereids) modify the binding aggregate function in order by#34606
morrySnow merged 2 commits into
apache:branch-2.0from
feiniaofeiafei:bind_order_2.0

feiniaofeiafei commented May 9, 2024•
edited
Loading

Uh oh!

doris-robot commented May 9, 2024

Uh oh!

feiniaofeiafei commented May 9, 2024

Uh oh!

feiniaofeiafei commented May 9, 2024

Uh oh!

doris-robot commented May 9, 2024

Uh oh!

doris-robot commented May 9, 2024

Uh oh!

doris-robot commented May 9, 2024

Uh oh!

doris-robot commented May 9, 2024

Uh oh!

feiniaofeiafei commented May 10, 2024

Uh oh!

github-actionsBot commented May 10, 2024

Uh oh!

github-actionsBot commented May 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

feiniaofeiafei commented May 9, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

doris-robot commented May 9, 2024

Uh oh!

feiniaofeiafei commented May 9, 2024

Uh oh!

feiniaofeiafei commented May 9, 2024

Uh oh!

doris-robot commented May 9, 2024

Uh oh!

doris-robot commented May 9, 2024

Uh oh!

doris-robot commented May 9, 2024

Uh oh!

doris-robot commented May 9, 2024

Uh oh!

feiniaofeiafei commented May 10, 2024

Uh oh!

github-actionsBot commented May 10, 2024

Uh oh!

github-actionsBot commented May 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feiniaofeiafei commented May 9, 2024•
edited
Loading