[Improve]delete match_element_xx and add fe config for create inverted index on array by amorynan · Pull Request #34766 · apache/doris

amorynan · 2024-05-13T08:00:45Z

Proposed changes

in this pr:

delete match_element_xx grammar for array
add a fe config enable_create_inverted_index_for_array array type which default is false

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

…n array

doris-robot · 2024-05-13T08:00:50Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

github-actions · 2024-05-13T08:07:04Z

clang-tidy review says "All clean, LGTM! 👍"

xiaokang · 2024-05-13T08:05:58Z

 | MAP
 | MATCH_ALL
 | MATCH_ANY
- | MATCH_ELEMENT_EQ


delete others

xiaokang · 2024-05-13T08:08:26Z

 public static boolean enable_create_bitmap_index_as_inverted_index = false;

+ @ConfField(mutable = true)
+ public static boolean enable_create_inverted_index_for_array = false;


If array_contains is OK, keep it true and disable index def with parser

maybe we also need it for 2.1 because here depends on this pr: #32620 enable expr push down storage layer to pass inverted index , but this feature is not gonna to be in 2.1

github-actions · 2024-05-13T08:39:50Z

clang-tidy review says "All clean, LGTM! 👍"

eldenmoon

may cause compability issue

github-actions · 2024-05-13T08:51:21Z

clang-tidy review says "All clean, LGTM! 👍"

amorynan · 2024-05-13T09:08:29Z

run buildall

doris-robot · 2024-05-13T09:51:13Z

TeamCity be ut coverage result:
Function Coverage: 35.66% (8983/25191)
Line Coverage: 27.32% (74273/271837)
Region Coverage: 26.56% (38389/144526)
Branch Coverage: 23.38% (19577/83738)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b167ab9194a9b4d91ffa4d548012b6d4a1f9893b_b167ab9194a9b4d91ffa4d548012b6d4a1f9893b/report/index.html

eldenmoon

LGTM

github-actions · 2024-05-14T01:50:55Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-05-14T01:50:57Z

PR approved by anyone and no changes requested.

…d index on array (apache#34766)

here with some array with inverted index bugfix: see also: #34766 #35086 #34683 #34076

…#35926) ## Proposed changes see also for branch-2.1: #35837 and master: #34766 #35086 #34683 #34076

…pache#34683 apache#34076 (apache#35926) ## Proposed changes see also for branch-2.1: apache#35837 and master: apache#34766 apache#35086 apache#34683 apache#34076

…d index on array (apache#34766)

delete match_element_xx and add fe config for create inverted index o…
2190f4b
…n array

github-actionsBot added the meta-change label May 13, 2024

xiaokang reviewed May 13, 2024
View reviewed changes

morrySnow reviewed May 13, 2024
View reviewed changes

Comment threadfe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4 Outdated

fix weird code
137357e

eldenmoon reviewed May 13, 2024
View reviewed changes

Comment threadgensrc/thrift/Opcodes.thrift

eldenmoon requested changes May 13, 2024
View reviewed changes

add deprecated note instead of delete for thrift param
b167ab9

eldenmoon approved these changes May 14, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label May 14, 2024

github-actionsBot added the reviewed label May 14, 2024

morrySnow approved these changes May 14, 2024
View reviewed changes

eldenmoon merged commit 75ad0ff into apache:masterMay 14, 2024

ByteYue pushed a commit to ByteYue/doris that referenced this pull request May 15, 2024
[Improve]delete match_element_xx and add fe config for create inverte…
f088a66
…d index on array (apache#34766)

This was referenced Jun 4, 2024
[FIX] Pick array inverted index bugfix #35837
Merged
[FIX](array)fix array with inverted index #35926
Merged

xiaokang pushed a commit that referenced this pull request Jun 6, 2024
[FIX] Pick array inverted index bugfix (#35837)
b5a35b9
here with some array with inverted index bugfix: see also: #34766 #35086 #34683 #34076

xiaokang added the dev/2.1.4-merged label Jun 12, 2024

xiaokang pushed a commit that referenced this pull request Jun 12, 2024
[FIX](array)fix array with inverted index#35837#34766#34683#34076(…
0bd451d
…#35926) ## Proposed changes see also for branch-2.1: #35837 and master: #34766 #35086 #34683 #34076

xiaokang added the dev/2.0.12-merged label Jun 12, 2024

dataroaring added the dev/3.0.0-merged label Aug 5, 2024

HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
[Improve]delete match_element_xx and add fe config for create inverte…
1b97969
…d index on array (apache#34766)

Uh oh!

Conversation

amorynan commented May 13, 2024

Proposed changes

Further comments

Uh oh!

doris-robot commented May 13, 2024

Uh oh!

github-actionsBot commented May 13, 2024

Uh oh!

xiaokangMay 13, 2024

Choose a reason for hiding this comment

Uh oh!

xiaokangMay 13, 2024

Choose a reason for hiding this comment

Uh oh!

amorynanMay 13, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented May 13, 2024

Uh oh!

eldenmoon left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented May 13, 2024

Uh oh!

amorynan commented May 13, 2024

Uh oh!

doris-robot commented May 13, 2024

Uh oh!

eldenmoon left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented May 14, 2024

Uh oh!

github-actionsBot commented May 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants