Skip to content

[FIX](array)fix index writer with add_array_values with first empty array for a batch - #35086

Merged
xiaokang merged 1 commit into
apache:masterfrom
amorynan:fix-array-inverted-index-with-empty-first
May 22, 2024
Merged

[FIX](array)fix index writer with add_array_values with first empty array for a batch#35086
xiaokang merged 1 commit into
apache:masterfrom
amorynan:fix-array-inverted-index-with-empty-first

Conversation

@amorynan

@amorynanamorynan commented May 20, 2024

Copy link
Copy Markdown
Contributor

Proposed changes

if first is empty array in coming batch data
fieldDataArray.values would not be initialized in ThreadState.init method,
then next array which to be inverted index will not be reset in Field because of this condition.
so we have to create a field into _doc to make thread init fieldDataArray
Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot

doris-robot commented May 20, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions

github-actionsBot commented May 20, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@amorynan

amorynan commented May 20, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented May 20, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 35.70% (9013/25248)
Line Coverage: 27.35% (74522/272515)
Region Coverage: 26.60% (38542/144914)
Branch Coverage: 23.43% (19665/83932)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7820eb5c7dc3079448c2c61c7599a94ba5ad51f0_7820eb5c7dc3079448c2c61c7599a94ba5ad51f0/report/index.html

zzzxl1993
zzzxl1993 approved these changes May 21, 2024
View reviewed changes

@zzzxl1993zzzxl1993 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented May 21, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

airborne12
airborne12 approved these changes May 21, 2024
View reviewed changes

@airborne12airborne12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xiaokang
xiaokang approved these changes May 22, 2024
View reviewed changes

@xiaokangxiaokang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label May 22, 2024
@github-actions

github-actionsBot commented May 22, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@xiaokang
xiaokang merged commit 866fddb into apache:masterMay 22, 2024
dataroaring pushed a commit that referenced this pull request May 26, 2024
amory@dataroaring
[fix](array) fix index writer with add_array_values with first empty …
d59290e
…array for a batch (#35086)
This was referenced Jun 4, 2024
Merged
Merged
xiaokang pushed a commit that referenced this pull request Jun 6, 2024
amory
[FIX] Pick array inverted index bugfix (#35837)
b5a35b9
here with some array with inverted index bugfix:
see also: #34766#35086#34683#34076
xiaokang pushed a commit that referenced this pull request Jun 12, 2024
amory
[FIX](array)fix array with inverted index#35837#34766#34683#34076(…
0bd451d
…#35926)
## Proposed changes
see also for branch-2.1: #35837
and master: #34766#35086#34683#34076
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
amorycaiconghui1
[FIX](array)fix array with inverted indexapache#35837apache#34766a…
a5b995c
…pache#34683apache#34076 (apache#35926)
## Proposed changes
see also for branch-2.1: apache#35837
and master:
apache#34766apache#35086apache#34683apache#34076
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
amory@HappenLee
[fix](array) fix index writer with add_array_values with first empty …
0c4385e
…array for a batch (apache#35086)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaokangxiaokangxiaokang approved these changes
@airborne12airborne12airborne12 approved these changes
@zzzxl1993zzzxl1993zzzxl1993 approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.0.12-mergeddev/2.1.4-mergeddev/3.0.0-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@amorynan@doris-robot@xiaokang@airborne12@zzzxl1993@yiguolei@dataroaring