Skip to content

[config](inverted index)Make inverted_index_ram_dir enable by default - #35094

Merged
qidaye merged 1 commit into
apache:masterfrom
qidaye:make_ram_dir_enable
May 21, 2024
Merged

[config](inverted index)Make inverted_index_ram_dir enable by default#35094
qidaye merged 1 commit into
apache:masterfrom
qidaye:make_ram_dir_enable

Conversation

@qidaye

@qidayeqidaye commented May 21, 2024

Copy link
Copy Markdown
Contributor

Proposed changes

inverted_index_ram_dir_enable can reduce disk IO in writing index time.
We turn it on by default.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot

doris-robot commented May 21, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@qidaye

qidaye commented May 21, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented May 21, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

airborne12
airborne12 approved these changes May 21, 2024
View reviewed changes

@airborne12airborne12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented May 21, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

xiaokang
xiaokang approved these changes May 21, 2024
View reviewed changes

@xiaokangxiaokang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot

doris-robot commented May 21, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 35.72% (9020/25251)
Line Coverage: 27.35% (74553/272584)
Region Coverage: 26.58% (38526/144953)
Branch Coverage: 23.42% (19660/83962)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2abe852576bb316550113f91766d340fa003e2a2_2abe852576bb316550113f91766d340fa003e2a2/report/index.html

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label May 21, 2024
@github-actions

github-actionsBot commented May 21, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@qidaye
qidaye merged commit c1ac282 into apache:masterMay 21, 2024
@qidaye
qidaye deleted the make_ram_dir_enable branch May 21, 2024 06:06
dataroaring pushed a commit that referenced this pull request May 26, 2024
@qidaye@luennng@dataroaring
[config](inverted index)Make inverted_index_ram_dir enable by default (…
f58cf6b
…#35094)
`inverted_index_ram_dir_enable` can reduce disk IO in writing index time.
We turn it on by default.
Co-authored-by: Luennng <luennng@gmail.com>
qidaye added a commit to qidaye/incubator-doris that referenced this pull request Aug 8, 2024
@qidaye@luennng
[config](inverted index)Make inverted_index_ram_dir enable by default (…
1da6ff4
…apache#35094)
`inverted_index_ram_dir_enable` can reduce disk IO in writing index time.
We turn it on by default.
Co-authored-by: Luennng <luennng@gmail.com>
@qidayeqidaye mentioned this pull request Aug 8, 2024
Merged
yiguolei pushed a commit that referenced this pull request Aug 8, 2024
@qidaye@luennng
[config](inverted index)Make inverted_index_ram_dir enable by default(#…
8678fce
…35094) (#39120)
## Proposed changes
bp #35094
Co-authored-by: Luennng <luennng@gmail.com>
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@qidaye@luennng@HappenLee
[config](inverted index)Make inverted_index_ram_dir enable by default (…
9149e2a
…apache#35094)
`inverted_index_ram_dir_enable` can reduce disk IO in writing index time.
We turn it on by default.
Co-authored-by: Luennng <luennng@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaokangxiaokangxiaokang approved these changes
@airborne12airborne12airborne12 approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.6-mergeddev/3.0.0-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@qidaye@doris-robot@xiaokang@airborne12@yiguolei@dataroaring@luennng